Uh oh!
There was an error while loading. Please reload this page.
test(nodejs): fix connection failure and recovery E2E test - #790
Merged
Conversation
Fixes the TODO test that was timing out by restructuring it to follow the pattern of other successful reconnection tests. The key change is queueing the recovery message WHILE the peer is down (which triggers reconnection logic) rather than AFTER the peer restarts. The test now: 1. Establishes initial connectivity 2. Stops the remote kernel to simulate failure 3. Queues a testConnection message (triggers reconnection) 4. Restarts the remote kernel 5. Verifies the recovery message completes successfully 6. Verifies ongoing connectivity with a follow-up message Closes#663 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sirtimid
enabled auto-merge
January 29, 2026 17:04
Contributor
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The key change is queueing the recovery message while the peer is down (which triggers reconnection logic) rather than after the peer restarts.
Test plan
yarn workspace @ocap/nodejs test:e2e:ci)Closes#663
🤖 Generated with Claude Code
Note
Low Risk
Test-only change that alters reconnection timing/ordering; low production risk but could affect E2E stability/flakiness if assumptions about recovery timing are wrong.
Overview
Enables the previously skipped
handles connection failure and recoveryE2E by restructuring it to queue the recovery message while the peer kernel is down, then restart the peer so the queued call drives reconnection.Adds explicit assertions for initial connectivity, successful recovery (
status: connectedand expectedpong), and a follow-up message to confirm the connection remains usable after restart.Written by Cursor Bugbot for commit 51bd597. This will update automatically on new commits. Configure here.