Skip to content

Add support for multiple chains - #130

Merged
jpuri merged 6 commits into
mainfrom
code_cleanup
Jan 16, 2024
Merged

Add support for multiple chains#130
jpuri merged 6 commits into
mainfrom
code_cleanup

Conversation

@jpuri

Copy link
Copy Markdown
Collaborator

Add support for multiple chains in PPOMController.

Fixes: MetaMask/MetaMask-planning#1808
Fixes: MetaMask/metamask-extension#21913

@jpuri
jpuri requested a review from a team as a code ownerJanuary 16, 2024 10:08
segun
segun previously approved these changes Jan 16, 2024

@segunsegun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadsrc/ppom-controller.ts Outdated
@segun

Copy link
Copy Markdown
Contributor

@jpuri

I used this branch in my extension PR but MM won't start and this error shows up in the console

lockdown-install.js:1 SES_UNHANDLED_REJECTION: Error: Event missing from allow list: NetworkController:stateChange
at RestrictedControllerMessenger.subscribe (RestrictedControllerMessenger.js:144:1)
at PPOMController._PPOMController_subscribeMessageEvents (ppom-controller.js:329:1)
at new PPOMController (ppom-controller.js:176:1)
at new MetamaskController (metamask-controller.js:713:27)
at setupController (background.js:504:16)
at initialize (background.js:287:5)

@jpuri

Copy link
Copy Markdown
CollaboratorAuthor

@jpuri

I used this branch in my extension PR but MM won't start and this error shows up in the console

lockdown-install.js:1 SES_UNHANDLED_REJECTION: Error: Event missing from allow list: NetworkController:stateChange
at RestrictedControllerMessenger.subscribe (RestrictedControllerMessenger.js:144:1)
at PPOMController._PPOMController_subscribeMessageEvents (ppom-controller.js:329:1)
at new PPOMController (ppom-controller.js:176:1)
at new MetamaskController (metamask-controller.js:713:27)
at setupController (background.js:504:16)
at initialize (background.js:287:5)

It requires a fix in extension, I will prepare once PPOMController deployment is done.

Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@jpuri
jpuri requested a review from segunJanuary 16, 2024 15:59
@jpuri
jpuri merged commit a51df37 into mainJan 16, 2024
@jpuri
jpuri deleted the code_cleanup branch January 16, 2024 16:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable support to blockaid on custom network - PPOMController

2 participants

@jpuri@segun