Skip to content

Adding controller - #4

Merged
jpuri merged 33 commits into
mainfrom
adding_controller
Jun 15, 2023
Merged

Adding controller#4
jpuri merged 33 commits into
mainfrom
adding_controller

Conversation

@jpuri

@jpurijpuri commented May 31, 2023

Copy link
Copy Markdown
Collaborator

@jpuri
jpuri requested review from a team, Gudahtt and mcmireMay 31, 2023 08:57
@MetaMaskMetaMask deleted a comment from socket-securityBotMay 31, 2023
@socket-security

socket-securityBot commented May 31, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @spruceid/siwe-parser@1.1.3, setimmediate@1.0.5, bs58@4.0.1, ripemd160@2.0.2, md5.js@1.3.5, rlp@2.2.7, node-gyp-build@4.6.0, @ethereumjs/common@3.1.2, @metamask/base-controller@3.0.0, @metamask/controller-utils@4.0.0, @metamask/utils@5.0.2, blakejs@1.2.1, browserify-aes@1.2.0, create-hash@1.2.0, create-hmac@1.1.7, minimalistic-assert@1.0.1, randombytes@2.1.0, superstruct@1.0.3, @chainsafe/ssz@0.11.1, micro-ftch@0.3.1, brorand@1.1.0, buffer-xor@1.0.3, is-hex-prefixed@1.0.0, ethereumjs-util@7.1.5, js-sha3@0.5.7, sha.js@2.4.11, strip-hex-prefix@1.0.0, ethjs-unit@0.1.6, eth-ens-namehash@2.0.8, @types/ms@0.7.31, crc-32@1.2.2, bn.js@4.11.6, bn.js@4.12.0, bn.js@5.2.1, number-to-bn@1.7.0, await-semaphore@0.1.3, evp_bytestokey@1.0.3, hash-base@3.1.0, scrypt-js@3.0.1, eth-rpc-errors@4.0.3, hash.js@1.1.7, elliptic@6.5.4, minimalistic-crypto-utils@1.0.1, cipher-base@1.0.4, pbkdf2@3.1.2, hmac-drbg@1.0.1, @types/secp256k1@4.0.3, fast-safe-stringify@2.1.1, base-x@3.0.9, @types/pbkdf2@3.1.0, apg-js@4.1.3, node-addon-api@2.0.2, @ethereumjs/rlp@4.0.1, keccak@3.0.3, secp256k1@4.0.3

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @jpuri
    jpuri marked this pull request as ready for review June 1, 2023 06:43
    @jpuri
    jpuri requested a review from a team as a code ownerJune 1, 2023 06:43
    @jpuri

    jpuri commented Jun 1, 2023

    Copy link
    Copy Markdown
    CollaboratorAuthor

    @SocketSecurity ignore-all

    Comment threadsrc/ppom-controller.ts Outdated
    @jpuri
    jpuri requested review from a teamJune 6, 2023 17:12
    Comment threadsrc/ppom-controller.ts
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.ts Outdated
    Comment threadsrc/ppom-controller.test.ts Outdated
    Comment threadsrc/ppom-controller.test.ts Outdated
    Comment threadsrc/ppom-controller.test.ts
    Comment threadsrc/ppom-controller.test.ts Outdated
    Comment threadsrc/ppom-controller.test.ts Outdated
    Comment threadsrc/ppom-controller.test.ts Outdated
    @socket-security

    Copy link
    Copy Markdown

    New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

    PackagesVersionNew capabilitiesTransitives1SizePublisher
    await-semaphore🆕0.1.3None+023.5 kBnotenoughneon
    @metamask/base-controller🆕3.0.0network+216.27 MBmetamaskbot
    @metamask/controller-utils🆕4.0.0network, filesystem, shell+6914.3 MBmetamaskbot

    Footnotes

    1. https://docs.socket.dev

    @jpuri

    jpuri commented Jun 8, 2023

    Copy link
    Copy Markdown
    CollaboratorAuthor

    @SocketSecurity ignore-all

    @jpuri
    jpuri requested review from matthewwalsh0 and segunJune 9, 2023 06:40
    @jpuri
    jpuriforce-pushed the adding_controller branch from 76d58ae to 3437bfbCompareJune 15, 2023 09:34
    @jpuri
    jpuri requested a review from matthewwalsh0June 15, 2023 09:36
    @jpuri
    jpuri merged commit 874be0c into mainJun 15, 2023
    @jpuri
    jpuri deleted the adding_controller branch June 15, 2023 09:49
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @jpuri@segun@matthewwalsh0