Uh oh!
There was an error while loading. Please reload this page.
Olu/enable ppom on more networks - #90
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jpuri
commented
Nov 22, 2023
@segun : Can you plz test the PR in extension to ensure that validation works on multiple chains, additionally caching data files and switching between networks should work well. |
bschorchit
commented
Nov 24, 2023
@segun would you mind also including Linea on this PR? - we have been unblocked for supporting this network too and are good to go |
d39226b to
c399d94Compare| callBack({ providerConfig: { chainId: '0x6' } }); | ||
| expect(Object.keys(ppomController.state.chainStatus)).toHaveLength(5); | ||
| jest.useFakeTimers().setSystemTime(new Date('2023-01-04')); |
There was a problem hiding this comment.
I needed to add one more because the condition in ppomController for this check to happen is > 5. It doesn't do the check if its <= 5
c399d94 to
2cf1cddCompare| chainStatus[chainId]?.versionInfo ?? | ||
| this.state.versionInfo.filter(({ chainId: id }) => id === chainId); | ||
| console.log('chainStatus 1008', chainStatus); | ||
| const hasVersionInfo = chainStatus[chainId]?.versionInfo?.length; |
There was a problem hiding this comment.
I noticed this part wasn't been called in tests because chainStatus[chainId]?.versionInfo is usually [] not undefined/null. So this check makes sure it works either it's undefined, null or []
Uh oh!
There was an error while loading. Please reload this page.
Ethereum Mainnet (already done) BNB chain Polygon Arbitrum Optimism Avalanche Test case for supported chain id Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Add linea mainnet to supported chain IDs. Lint fixes Fix tests Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
33e1943 to
4976b8cCompare
We should enabled PPOM on the following networks:
Ethereum Mainnet (already done)
BNB chain
Polygon
Arbitrum
Optimism
Avalanche
Linea
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1693