Skip to content

Use @metamask/json-rpc-engine and @metamask/rpc-errors - #253

Merged
legobeat merged 5 commits into
mainfrom
fb/bump-json-rpc-engine
Sep 5, 2023
Merged

Use @metamask/json-rpc-engine and @metamask/rpc-errors#253
legobeat merged 5 commits into
mainfrom
fb/bump-json-rpc-engine

Conversation

@FrederikBolding

@FrederikBoldingFrederikBolding commented Apr 19, 2023

Copy link
Copy Markdown
Member

No description provided.

@socket-security

socket-securityBot commented Apr 19, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@FrederikBolding
FrederikBoldingforce-pushed the fb/bump-json-rpc-engine branch from 2285e51 to 0f93326CompareJuly 14, 2023 12:18
@socket-security

socket-securityBot commented Jul 14, 2023

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@metamask/rpc-errors6.0.0None+091.8 kBmetamaskbot

🚮 Removed packages:eth-rpc-errors@4.0.3, json-rpc-engine@6.1.0

@legobeat

Copy link
Copy Markdown
Contributor

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Sep 2, 2023
legobeat
legobeat previously approved these changes Sep 2, 2023
@legobeat
legobeat marked this pull request as ready for review September 2, 2023 06:52
@legobeat
legobeat requested a review from a team as a code ownerSeptember 2, 2023 06:52
@legobeat

legobeat commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

The restriction in exported type makes this a breaking change. Therefore:

Blocked by

Blocks

This was referenced Sep 2, 2023
Merged
Merged
@legobeat
legobeat requested review from a team and MrtenzSeptember 4, 2023 07:45
FrederikBoldingand others added 5 commits September 4, 2023 17:56
* deps: @metamask/rpc-errors@^5.1.1->^6.0.0
* deps:@metamask/utils@^6.2.0->^7.1.0
* update @metamask/utils v7 usage
* deps: @metamask/json-rpc-engine@^7.0.0->^7.1.1
* test: type fixes
@legobeat
legobeat requested review from a team and leotmSeptember 4, 2023 09:22
@legobeat
legobeat merged commit 080979d into mainSep 5, 2023
@legobeat
legobeat deleted the fb/bump-json-rpc-engine branch September 5, 2023 07:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@FrederikBolding@legobeat@Mrtenz