Uh oh!
There was an error while loading. Please reload this page.
deps: Update to streams3 API - #288
Conversation
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages:@types/readable-stream@2.3.15 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
d594081 to
c5e9dc1Compareset subdep readable-stream to ^3.6.2 in resolutions
legobeat
commented
Oct 27, 2023
|
Uh oh!
There was an error while loading. Please reload this page.
jiexi
commented
Oct 27, 2023
I mean, the tests pass. We probably want to test this locally in extension and see what happens. I imagine it'll just work though |
jiexi
commented
Nov 7, 2023
Tested locally. Seems to work fine |
Changed
readable-stream@3.x.extension-port-streamfrom^2.1.1to^3.0.0json-rpc-middleware-streamfrom^4.2.3to^5.0.1@metamask/object-multiplexfrom^1.3.0to^2.0.0readable-stream@^3.6.2The package is previously mixing usage of
readable-stream@2,readable-stream@3and Node.js native streams (the API and behavior of which differ depending on Node.js version). This consolidates all internal streams on portablereadable-stream.