Skip to content

deps: Update to streams3 API - #288

Merged
legobeat merged 5 commits into
MetaMask:mainfrom
legobeat:streams-v3
Nov 7, 2023
Merged

deps: Update to streams3 API#288
legobeat merged 5 commits into
MetaMask:mainfrom
legobeat:streams-v3

Conversation

@legobeat

@legobeatlegobeat commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Changed

The package is previously mixing usage of readable-stream@2, readable-stream@3 and Node.js native streams (the API and behavior of which differ depending on Node.js version). This consolidates all internal streams on portable readable-stream.

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Oct 26, 2023
@socket-security

socket-securityBot commented Oct 26, 2023

Copy link
Copy Markdown

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
extension-port-stream2.1.1...3.0.0None+2/-057 kB
json-rpc-middleware-stream4.2.3...5.0.1None+2/-667 kBgudahtt
@metamask/object-multiplex1.3.0...2.0.0None+2/-759.7 kBlgbot

🚮 Removed packages:@types/readable-stream@2.3.15

This was referenced Oct 26, 2023
Merged
@socket-security

socket-securityBot commented Oct 27, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: extension-port-stream@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @legobeat
    legobeatforce-pushed the streams-v3 branch 2 times, most recently from d594081 to c5e9dc1CompareOctober 27, 2023 04:25
    set subdep readable-stream to ^3.6.2 in resolutions
    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore extension-port-stream@3.0.0
    

    @legobeat
    legobeat requested a review from jiexiOctober 27, 2023 04:34
    @legobeat
    legobeat marked this pull request as ready for review October 27, 2023 04:34
    @legobeat
    legobeat requested a review from a team as a code ownerOctober 27, 2023 04:34
    Comment thread.eslintrc.js
    @jiexi

    Copy link
    Copy Markdown
    Member

    I mean, the tests pass. We probably want to test this locally in extension and see what happens. I imagine it'll just work though

    @legobeat
    legobeat requested a review from jiexiNovember 7, 2023 21:49
    @jiexi

    jiexi commented Nov 7, 2023

    Copy link
    Copy Markdown
    Member

    Tested locally. Seems to work fine

    @legobeat
    legobeat merged commit 024925d into MetaMask:mainNov 7, 2023
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @legobeat@jiexi