Skip to content

devDeps: @lavamoat/allow-scripts@2.0.3->2.3.1 - #109

Merged
legobeat merged 4 commits into
MetaMask:mainfrom
legobeat:devDeps-lavamoat-allow-scripts
Oct 10, 2023
Merged

devDeps: @lavamoat/allow-scripts@2.0.3->2.3.1#109
legobeat merged 4 commits into
MetaMask:mainfrom
legobeat:devDeps-lavamoat-allow-scripts

Conversation

@legobeat

@legobeatlegobeat commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@socket-security

socket-securityBot commented Aug 31, 2023

Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@lavamoat/allow-scripts2.1.0...2.3.1network, shell+74/-657.07 MBlgbot

@socket-security

socket-securityBot commented Aug 31, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @lavamoat/allow-scripts@2.3.1, json-parse-even-better-errors@3.0.0, @npmcli/node-gyp@3.0.0, are-we-there-yet@3.0.1, npmlog@6.0.2, read-cmd-shim@4.0.0, npm-normalize-package-bin@3.0.1, which@3.0.1, write-file-atomic@5.0.1, nopt@6.0.0, exponential-backoff@3.1.1, foreground-child@3.1.1, make-fetch-happen@11.1.1, minipass-fetch@3.0.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore @lavamoat/preinstall-always-fail@1.0.0
    

    maintenance ok

    @legobeat
    legobeat marked this pull request as ready for review August 31, 2023 22:15
    @legobeat
    legobeat requested a review from a team as a code ownerAugust 31, 2023 22:15
    @legobeat
    legobeatforce-pushed the devDeps-lavamoat-allow-scripts branch from de51bbf to 1c8df5fCompareSeptember 1, 2023 00:46
    mcmire
    mcmire previously approved these changes Oct 5, 2023

    @mcmiremcmire left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good!

    @legobeat
    legobeatforce-pushed the devDeps-lavamoat-allow-scripts branch from 1c8df5f to 48c5ab4CompareOctober 7, 2023 02:46
    @legobeat
    legobeat requested a review from a teamOctober 7, 2023 02:46
    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore @lavamoat/allow-scripts@2.3.1
    @SocketSecurity ignore json-parse-even-better-errors@3.0.0
    @SocketSecurity ignore @npmcli/node-gyp@3.0.0
    @SocketSecurity ignore are-we-there-yet@3.0.1
    @SocketSecurity ignore npmlog@6.0.2
    @SocketSecurity ignore read-cmd-shim@4.0.0
    @SocketSecurity ignore npm-normalize-package-bin@3.0.1
    @SocketSecurity ignore which@3.0.1
    @SocketSecurity ignore write-file-atomic@5.0.1
    @SocketSecurity ignore nopt@6.0.0
    @SocketSecurity ignore exponential-backoff@3.1.1
    @SocketSecurity ignore foreground-child@3.1.1
    @SocketSecurity ignore make-fetch-happen@11.1.1
    @SocketSecurity ignore minipass-fetch@3.0.4
    

    @legobeat
    legobeat merged commit 1d9c25c into MetaMask:mainOct 10, 2023
    @legobeat
    legobeat deleted the devDeps-lavamoat-allow-scripts branch October 10, 2023 00:33
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @legobeat@mcmire@Mrtenz