Skip to content

Fix snaps-controllers and snaps-execution-environments tests - #1835

Merged
Mrtenz merged 4 commits into
fb/bump-json-rpc-engine-et-allfrom
mrtenz/fix-snaps-controllers-tests
Oct 11, 2023
Merged

Fix snaps-controllers and snaps-execution-environments tests#1835
Mrtenz merged 4 commits into
fb/bump-json-rpc-engine-et-allfrom
mrtenz/fix-snaps-controllers-tests

Conversation

@Mrtenz

@MrtenzMrtenz commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This fixes the Snaps controllers and execution environments tests on #1818.

@MrtenzMrtenz changed the title Fix snaps-controllers testsFix snaps-controllers and snaps-execution-environments testsOct 10, 2023
@codecov

codecovBot commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (fb/bump-json-rpc-engine-et-all@3c6782f). Click here to learn what that means.

Additional details and impacted files
@@ Coverage Diff @@## fb/bump-json-rpc-engine-et-all #1835 +/- ##
=================================================================
Coverage ? 95.96% =================================================================
Files ? 241 Lines ? 5602 Branches ? 885 =================================================================
Hits ? 5376 Misses ? 226 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz
Mrtenz marked this pull request as ready for review October 10, 2023 14:08
@Mrtenz
Mrtenz requested a review from a team as a code ownerOctober 10, 2023 14:08
FrederikBolding
FrederikBolding reviewed Oct 11, 2023
View reviewed changes
Comment threadpackages/snaps-controllers/src/services/node/NodeThreadExecutionService.test.ts
Comment threadpackages/snaps-controllers/src/services/node/NodeThreadExecutionService.test.ts
Comment threadpackages/snaps-controllers/src/services/node/NodeProcessExecutionService.test.ts
Comment threadpackages/snaps-controllers/src/services/node/NodeProcessExecutionService.test.ts
@Mrtenz
Mrtenz merged commit 8c9ba92 into fb/bump-json-rpc-engine-et-allOct 11, 2023
@Mrtenz
Mrtenz deleted the mrtenz/fix-snaps-controllers-tests branch October 11, 2023 09:23
FrederikBolding pushed a commit that referenced this pull request Oct 11, 2023
@Mrtenz@FrederikBolding
Fixsnaps-controllersandsnaps-execution-environmentstests (#1835)
8b0ed91
This fixes the Snaps controllers and execution environments tests on
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrederikBoldingFrederikBoldingFrederikBolding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mrtenz@FrederikBolding