Uh oh!
There was an error while loading. Please reload this page.
deps(snaps-controllers): @metamask/object-multiplex@^1.2.0->^2.0.0 - #1927
deps(snaps-controllers): @metamask/object-multiplex@^1.2.0->^2.0.0#1927legobeat wants to merge 2 commits into
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
7ae0d09 to
7fb2030CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1927 +/- ##
=======================================
Coverage 96.13% 96.13% =======================================
Files 261 261 Lines 6062 6062 Branches 989 989 =======================================
Hits 5828 5828 Misses 234 234 ☔ View full report in Codecov by Sentry. |
| "@metamask/base-controller": "^3.2.0", | ||
| "@metamask/json-rpc-engine": "^7.1.1", | ||
| "@metamask/object-multiplex": "^1.2.0", | ||
| "@metamask/object-multiplex": "^2.0.0", |
There was a problem hiding this comment.
@legobeat Can we bump this across all the snaps monorepo packages?
There was a problem hiding this comment.
I assume this is what will be done eventually. However, it seems to imply quite a bit more (update of providers and some further changes?) when done in snaps-execution-environment:
https://github.com/MetaMask/snaps/actions/runs/6792674292/job/18466373634
https://github.com/legobeat/snaps-monorepo/pull/5/checks
So this PR currently aims at sidestepping that for the moment in order to allow getting @metamask/providers into @metamask/keyring-api.
Think it's worth pushing for doing the full update across the board in one larger update instead?
There was a problem hiding this comment.
Our Yarn constraints require that we use the same dependency versions across all packages.
There was a problem hiding this comment.
Yes: I am considering inserting a temporary exception for that, here, until @metamask/snaps-execution-environment is also bumped.
There was a problem hiding this comment.
Hmm could be that providers v14 needs some more attention to bump 🤔
7b186ba to
ea118c7Compare7ccf160 to
3c03a95CompareDraft WIP for also bumping the same dependency in |
…or @metamask/object-multiplex - @metamask/object-multiplex temporarily different versions in @metamask/snaps-controllers(^2.0.0) vs @metamask/snaps-execution-environments(^1.2.0)
3c03a95 to
439e14dCompareFrederikBolding
commented
Nov 17, 2023
Closing in favor of #1964 |
@metamask/snaps-controllers: BREAKING: Bump@metamask/object-multiplexfrom^1.2.0to^2.0.0Blocking