Skip to content

Fix tests - #7

Merged
Mrtenz merged 1 commit into
mainfrom
mrtenz/fix-tests
Mar 1, 2024
Merged

Fix tests#7
Mrtenz merged 1 commit into
mainfrom
mrtenz/fix-tests

Conversation

@Mrtenz

Copy link
Copy Markdown
Member

I made a few small mistakes in #4, causing the tests to break. This fixes it.

Blocked by #5.

Comment threadsrc/structs/types.ts
for (const { validate } of Structs) {
const [error, coerced] = validate(value, { coerce: true });
for (const InnerStruct of Structs) {
const [error, coerced] = InnerStruct.validate(value, { coerce: true });

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was broken because Struct.validate references this.

Base automatically changed from mrtenz/tsup to mainMarch 1, 2024 17:59
@Mrtenz
Mrtenz marked this pull request as ready for review March 1, 2024 20:48
@Mrtenz
Mrtenz requested a review from a teamMarch 1, 2024 20:48

@mcmiremcmire left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mrtenz
Mrtenz merged commit 734f725 into mainMar 1, 2024
@Mrtenz
Mrtenz deleted the mrtenz/fix-tests branch March 1, 2024 22:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Mrtenz@mcmire