Skip to content

update instances of collectibles to nfts - #199

Open
NidhiKJha wants to merge 10 commits into
mainfrom
collectibles-to-nft
Open

update instances of collectibles to nfts#199
NidhiKJha wants to merge 10 commits into
mainfrom
collectibles-to-nft

Conversation

@NidhiKJha

@NidhiKJhaNidhiKJha commented Dec 13, 2022

Copy link
Copy Markdown
Member

This PR is to update collectibles to nfts.

Reference: MetaMask/metamask-extension#16889

Code for Abis and bytecode:

pragma solidity ^0.8.7;
import "@openzeppelin/contracts@4.8.1/token/ERC721/ERC721.sol";
contract MyToken is ERC721 {
constructor() ERC721("NFT Token", "NFT") {}
function safeMint(uint256 tokenId) public {
_safeMint(msg.sender, tokenId);
}
}

@NidhiKJha
NidhiKJha requested a review from a team as a code ownerDecember 13, 2022 13:37
Comment threadsrc/index.html Outdated
Comment threadsrc/constants.json
Comment threadsrc/constants.json
Comment threadsrc/index.html Outdated
@Gudahtt

Copy link
Copy Markdown
Member

In a recent PR, the source code for the old "Collectibles" contract was added to the repository (in the contracts directory). Could you replace that contract with the source code for the new one?

Comment threadsrc/index.js Outdated
@@ -1,25 +1,21 @@
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.22 <0.9.0;

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried compiling this in Remix but got an error about Strings already being declared. I don't quite understand why, but, it went away with I removed the @4.8.1 or added it to the other two imports. Perhaps they should all be using the same version of @openzeppelin/contracts.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NidhiKJha@Gudahtt@mcmire