Skip to content

feat: Add PPOM setApprovalForAll button. Add token symbols for PPOM buttons - #258

Merged
digiwand merged 6 commits into
mainfrom
feat-add-ppom-set-approval-for-all-and-erc721-transfer-farming
Sep 29, 2023
Merged

feat: Add PPOM setApprovalForAll button. Add token symbols for PPOM buttons#258
digiwand merged 6 commits into
mainfrom
feat-add-ppom-set-approval-for-all-and-erc721-transfer-farming

Conversation

@digiwand

@digiwanddigiwand commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

This PR:

  • Adds Malicious Set Approval For All button
  • Adds token symbols to PPOM buttons

note: We are not adding Malicious ERC721 Transfer because the user would need to hold an asset of the specific punk collection in order for the simulation to detect potential loses.

@digiwand
digiwand marked this pull request as ready for review September 28, 2023 23:52
@digiwanddigiwand changed the title feat: Add PPOM setApprovalForAll and ERC721 buttonsfeat: Add PPOM setApprovalForAll button. Add token symbols for PPOM buttonsSep 29, 2023
@seaona

Copy link
Copy Markdown
Member

code LGTM, and I can see it working fine locally

Screenshot from 2023-09-29 15-30-00

@digiwand
digiwand merged commit 3bf67e3 into mainSep 29, 2023
@digiwand
digiwand deleted the feat-add-ppom-set-approval-for-all-and-erc721-transfer-farming branch September 29, 2023 14:04
@seaonaseaona mentioned this pull request Oct 10, 2023
@adonesky1adonesky1 mentioned this pull request Oct 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@digiwand@seaona@blackdevelopa