Skip to content

feat: add Uint8Array compare function - #268

Merged
hmalik88 merged 5 commits into
mainfrom
hm/add-uint8array-compare
Sep 9, 2025
Merged

feat: add Uint8Array compare function#268
hmalik88 merged 5 commits into
mainfrom
hm/add-uint8array-compare

Conversation

@hmalik88

Copy link
Copy Markdown
Contributor

Adding a compare function for Uint8 arrays. This compare function can be useful in various packages e.g. comparing mnemonics.

cursor[bot]

This comment was marked as outdated.

Comment threadsrc/bytes.ts
Comment threadsrc/bytes.test.ts Outdated
Comment threadsrc/bytes.ts Outdated
Comment threadsrc/bytes.ts Outdated
fabiobozzo
fabiobozzo previously approved these changes Sep 8, 2025

@fabiobozzofabiobozzo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrtenzMrtenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because of open question above.

Comment threadsrc/bytes.ts
@hmalik88
hmalik88 requested a review from MrtenzSeptember 9, 2025 14:56
@hmalik88
hmalik88 merged commit 90ec3a7 into mainSep 9, 2025
22 checks passed
@hmalik88
hmalik88 deleted the hm/add-uint8array-compare branch September 9, 2025 15:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hmalik88@fabiobozzo@Mrtenz