Skip to content

Export new modules - #86

Merged
gantunesr merged 3 commits into
mainfrom
export-new-types
Feb 20, 2023
Merged

Export new modules#86
gantunesr merged 3 commits into
mainfrom
export-new-types

Conversation

@gantunesr

Copy link
Copy Markdown
Member

This PR exports the new modules introduced in #74.

@gantunesr
gantunesr requested a review from a team as a code ownerFebruary 20, 2023 19:14
Gudahtt
Gudahtt previously approved these changes Feb 20, 2023

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr
gantunesr merged commit b3212b0 into mainFeb 20, 2023
@gantunesr
gantunesr deleted the export-new-types branch February 20, 2023 19:19
@Mrtenz

Copy link
Copy Markdown
Member

I wonder if we can add a check in CI for this. 🤔

@gantunesr

Copy link
Copy Markdown
MemberAuthor

I think it's, but I guess there could be cases that we don't to expose a module and only use it internally.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gantunesr@Mrtenz@Gudahtt