Uh oh!
There was an error while loading. Please reload this page.
Hotfix/deep copy support - #28
Conversation
- Clean up duplicate entries in yaml configs - Refactor deep-copy: use prepared statements and bind values for inserts
Set psalm version to 5.26.1
| $widget | ||
| ->expects(self::any()) | ||
| ->method('import') | ||
| ->withConsecutive([Config::class, 'Config']); |
There was a problem hiding this comment.
shouldn't this whole block rathe be:
$widget
->expects($this->once())
->method('import')
->with(Config::class, 'Config');
There was a problem hiding this comment.
It looks like the "import" call has been removed.
Uh oh!
There was an error while loading. Please reload this page.
| trusted-keys: | ||
| # composer-require-checker | ||
| - 033E5F8D801A2F8D | ||
| - B2BDAAAC6F1FDE528CD9EEC9033E5F8D801A2F8D |
There was a problem hiding this comment.
While these are not wrong, they point to a bug in phpcq... Apparently the cli of gnupg uses a different key fingerprint hash len than the php pgp extension.
We should fix this upstream and then remove them here again.
stefanheimes
commented
Jan 27, 2026
@discordier I've made a few updates. However, the "import" call has been removed from the phpunit section. Could you please take another look at it via the pull request? |
| $this->assertInstanceof(Config::class, $parameters[0]); | ||
| $this->assertSame('Config', $parameters[1]); | ||
| }); | ||
| ->with(Config::class, 'Config'); |
There was a problem hiding this comment.
When using never, "with" doesn't make sense at all.
Uh oh!
There was an error while loading. Please reload this page.
Description
Please explain the detailed changes you made here.
Reference any issue number this pull request fixes.
Checklist
@authorsin touched PHP files