Skip to content

Removed version_compare for >= 3.1 - #16

Merged
stefanheimes merged 1 commit into
MetaModels:masterfrom
cboelter:feature/contao-compatibility
Sep 27, 2016
Merged

Removed version_compare for >= 3.1#16
stefanheimes merged 1 commit into
MetaModels:masterfrom
cboelter:feature/contao-compatibility

Conversation

@cboelter

Copy link
Copy Markdown
Contributor

This PR removes a few lines of code that are not longer needed, because MetaModels support only Contao from version 3.2. So we don't need a compare for versions from 3.1, composer handles that for us.

@discordier

Copy link
Copy Markdown
Member

Could you please fix the build issues?
Looks good except for that.

@discordier

Copy link
Copy Markdown
Member

Build issues have been fixed in #16.

Thanks.

@discordierdiscordier self-assigned this Jul 13, 2016
@discordierdiscordier added this to the 2.0.0 milestone Jul 13, 2016
@discordierdiscordier modified the milestones: 2.0.1, 2.0.0Aug 3, 2016
stefanheimes added a commit that referenced this pull request Sep 27, 2016
Hotfix release:
- Merge PR #14, hotfix save NULL at empty values
- Merge PR #16, removed version_compare
@stefanheimes
stefanheimes merged commit cdb83e8 into MetaModels:masterSep 27, 2016
stefanheimes added a commit that referenced this pull request Sep 27, 2016
Hotfix release:
- Merge PR #14, hotfix save NULL at empty values
- Merge PR #16, removed version_compare
discordier added a commit that referenced this pull request Sep 28, 2016
Hotfix release:
- Merge PR #14, hotfix save NULL at empty values
- Merge PR #16, removed version_compare
discordier added a commit that referenced this pull request Sep 28, 2016
Hotfix release:
- Merge PR #14, hotfix save NULL at empty values
- Merge PR #16, removed version_compare
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cboelter@discordier@stefanheimes