Uh oh!
There was an error while loading. Please reload this page.
Register seven Meshenger-authored ontologies (Relation, AvailabilityStatus, ChatPreference, DraftMessage, Summary, PreferredHandlers, FileContext) - #1103
Open
EgorPPS wants to merge 1 commit into
Conversation
Relation, AvailabilityStatus, ChatPreference, DraftMessage, Summary, PreferredHandlers, FileContext — all seven have been in production use by Meshenger (meshenger.postplatforms.com) and are declared in its published self-description, but were never registered here, so no other platform could resolve their schemaIds. Field sets are derived from the envelopes actually written in production, required-fields cover only what is always written, and additionalProperties stays true: the registry has no versioning mechanism, so readers must tolerate additive fields. Relation is deliberately distinct from the existing Reference (c20e9437-…): Reference is a review/score OF a target; Relation is a reified triple BETWEEN envelopes (reactions, pins, mentions, responses) and its description says so to keep the two from being conflated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughAdded seven Draft-07 JSON schemas for ontology records covering availability, chat preferences, draft messages, file context, relations, preferred handlers, and summaries. ChangesOntology schemas
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/ontology/schemas/summary.json`:
- Around line 30-34: Update the summary schema’s conditional validation so
objects with isReference set to true require both canonicalOwnerEName and
canonicalSummaryId, using Draft-07 if/then syntax. Leave non-reference objects
subject to the existing validation rules.
- Around line 10-20: Update the subject schema to require the kind property and
constrain it with an enum allowing only “call” and “day”. Preserve the existing
subject object and other properties while ensuring empty subjects and
unsupported kind values fail validation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8fdd0d93-e0e8-43b5-846f-f76014d0ed4a
📒 Files selected for processing (7)
services/ontology/schemas/availabilityStatus.jsonservices/ontology/schemas/chatPreference.jsonservices/ontology/schemas/draftMessage.jsonservices/ontology/schemas/fileContext.jsonservices/ontology/schemas/preferredHandlers.jsonservices/ontology/schemas/relation.jsonservices/ontology/schemas/summary.json
Comment on lines
+10
to
+20
| "subject": { | ||
| "type": "object", | ||
| "description": "What is summarised: {kind: 'call'|'day', chatId?, callId?, dayKey?, ref?} — `ref` is a w3ds envelope URI of the source", | ||
| "properties": { | ||
| "kind": { "type": "string" }, | ||
| "chatId": { "type": "string" }, | ||
| "callId": { "type": "string" }, | ||
| "dayKey": { "type": "string", "description": "YYYY-MM-DD for a day digest" }, | ||
| "ref": { "type": "string" } | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Require and constrain subject.kind.
subject: {} and {"kind":"other"} both validate. The documented contract permits only call or day. Consumers cannot reliably select the summary subject type.
Proposed fix
- "kind": { "type": "string" },+ "kind": { "type": "string", "enum": ["call", "day"] },
"chatId": { "type": "string" },
"callId": { "type": "string" },
"dayKey": { "type": "string", "description": "YYYY-MM-DD for a day digest" },
"ref": { "type": "string" }
- }+ },+ "required": ["kind"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "subject": { | |
| "type": "object", | |
| "description": "What is summarised: {kind: 'call'|'day', chatId?, callId?, dayKey?, ref?} — `ref` is a w3ds envelope URI of the source", | |
| "properties": { | |
| "kind": { "type": "string" }, | |
| "chatId": { "type": "string" }, | |
| "callId": { "type": "string" }, | |
| "dayKey": { "type": "string", "description": "YYYY-MM-DD for a day digest" }, | |
| "ref": { "type": "string" } | |
| } | |
| }, | |
| "subject": { | |
| "type": "object", | |
| "description": "What is summarised: {kind: 'call'|'day', chatId?, callId?, dayKey?, ref?} — `ref` is a w3ds envelope URI of the source", | |
| "properties": { | |
| "kind": { "type": "string", "enum": ["call", "day"] }, | |
| "chatId": { "type": "string" }, | |
| "callId": { "type": "string" }, | |
| "dayKey": { "type": "string", "description": "YYYY-MM-DD for a day digest" }, | |
| "ref": { "type": "string" } | |
| }, | |
| "required": ["kind"] | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@services/ontology/schemas/summary.json` around lines 10 - 20, Update the
subject schema to require the kind property and constrain it with an enum
allowing only “call” and “day”. Preserve the existing subject object and other
properties while ensuring empty subjects and unsupported kind values fail
validation.
Comment on lines
+30
to
+34
| "isReference": { "type": "boolean" }, | ||
| "canonicalOwnerEName": { "type": "string" }, | ||
| "canonicalSummaryId": { "type": "string" }, | ||
| "sharedBy": { "type": "string" }, | ||
| "sharedAt": { "type": "string", "format": "date-time" } |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Require a canonical locator for references.
An object with "isReference": true validates without canonicalOwnerEName or canonicalSummaryId. A client then cannot resolve the canonical summary. Add a Draft-07 if/then constraint that requires both fields when isReference is true.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@services/ontology/schemas/summary.json` around lines 30 - 34, Update the
summary schema’s conditional validation so objects with isReference set to true
require both canonicalOwnerEName and canonicalSummaryId, using Draft-07 if/then
syntax. Leave non-reference objects subject to the existing validation rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven ontologies Meshenger has been writing in production and declaring in its self-description (https://meshenger.postplatforms.com/.well-known/w3ds-platform.json), never registered here — so other platforms could not resolve their schemaIds. This closes the gap.
f9ff8527-…Reference(review/score of a target) — the description spells the difference out.47478875-…eb69c8ad-…55606983-…5b1a2c3d-…9a1b2c3d-…b65218b4-…Field sets are taken from the envelopes production actually writes (not aspirational);
requiredcovers only fields that are always present, andadditionalProperties: truebecause the registry has no versioning — readers must ignore unknown additive fields. Reference/merge conventions these schemas participate in are documented in the Meshenger self-description.🤖 Generated with Claude Code
Summary by CodeRabbit