Uh oh!
There was an error while loading. Please reload this page.
Feat/eid reclaim - #349
Merged
Merged
Conversation
Contributor
Caution Review failedThe pull request is closed. WalkthroughAdds a pluggable key management layer (hardware/software) with a factory, refactors onboarding/verify flows to use it, enhances eVault profile creation with retries, and extends provisioning to handle duplicates via linkedEName/w3id with migration and event updates. Adds logging/guards in Cerberus flows and bumps Settings version text. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor UI as UI (Onboarding/Verify)
participant KMF as KeyManagerFactory
participant HW as HardwareKeyManager
participant SW as SoftwareKeyManager
UI->>KMF: getKeyManager(config/context)
alt pre-verification
KMF-->>UI: SW instance
else try hardware
KMF->>HW: probe exists(testKey)
alt hardware available
KMF-->>UI: HW instance
else fallback
KMF-->>UI: SW instance
end
end
UI->>KMF: generate/getPublicKey/sign/verify via manager
KMF-->>UI: result or KeyManagerError(code)
sequenceDiagram
autonumber
actor VerifyUI as Verify UI
participant Prov as Provisioner API
participant VC as VerificationController
participant VS as VerificationService
participant EE as EventEmitter
VerifyUI->>Prov: Start verification (SSE/WebSocket)
Prov->>VC: Create session
VC-->>EE: emit { status: pending }
VC->>VS: evaluate documents
alt duplicate detected
VC-->>EE: emit { status: duplicate, w3id }
else approved
VC-->>EE: emit { status: approved }
Prov->>VS: update(verificationId,{ linkedEName: w3id })
Prov-->>VerifyUI: provision eVault with w3id
end
Note over VerifyUI: If duplicate, claim existing eVault using w3id
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (17)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
coodos added a commit
that referenced
this pull request
Nov 4, 2025
* chore: cerberus debug loggin * feat: eid-reclaim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit