Uh oh!
There was an error while loading. Please reload this page.
Feat/swipe gesture - #410
Conversation
WalkthroughAdded a Tauri process plugin and permission, initialized process and notification plugins in the Tauri app builder, implemented a swipe-detection utility and exported it, and attached swipe-to-navigate (history.back on right swipe) to the main layout. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Tauri App Builder
participant Plugins as Plugins (process, notification)
participant Layout as +layout.svelte
participant SwipeUtil as swipedetect
participant Browser as Browser History
rect rgba(200,220,255,0.15)
App->>Plugins: init() plugins
Plugins-->>App: initialized
end
rect rgba(200,255,220,0.12)
Layout->>SwipeUtil: attach to mainWrapper (onMount)
SwipeUtil-->>Layout: emits "right" or "left"
alt right swipe
Layout->>Browser: window.history.back()
else left swipe
Layout-->>Layout: no-op
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
infrastructure/eid-wallet/src-tauri/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
infrastructure/eid-wallet/src-tauri/Cargo.toml(1 hunks)infrastructure/eid-wallet/src-tauri/capabilities/mobile.json(1 hunks)infrastructure/eid-wallet/src-tauri/src/lib.rs(3 hunks)infrastructure/eid-wallet/src/lib/utils/index.ts(1 hunks)infrastructure/eid-wallet/src/lib/utils/swipeGesture.ts(1 hunks)infrastructure/eid-wallet/src/routes/+layout.svelte(2 hunks)
🔇 Additional comments (2)
infrastructure/eid-wallet/src-tauri/capabilities/mobile.json (2)
16-17: Verify necessity ofprocess:defaultpermission for swipe gesture feature.The JSON syntax is correct, and the trailing comma addition on line 16 is properly formatted. However, the
process:defaultpermission typically enables execution of external processes/commands on the device. Given that this PR focuses on swipe gesture detection for back navigation, it's unclear why process capability is needed.Please clarify:
- Is the
process:defaultpermission actually required for the swipe gesture feature?- If yes, what specific process operations are performed?
- If no, this permission should be removed to follow least-privilege security principles.
You may want to review the changes in
src-tauri/src/lib.rsand the gesture implementation to confirm the process plugin is actually used by the swipe gesture handler.
8-18: Ensure consistent permission naming and scope.The permissions array follows Tauri's naming convention (
plugin-name:capability-level). Verify that all newly added permissions align with:
- The declared dependencies in
Cargo.toml(ensuretauri-plugin-process = "2"or later is declared)- The plugin initialization in
src-tauri/src/lib.rs(ensuretauri_plugin_processis registered)- Platform-specific requirements (process capability may have different availability/restrictions on iOS vs. Android)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
infrastructure/eid-wallet/src/lib/utils/swipeGesture.ts (1)
39-39: Fix reversed swipe direction mapping.The ternary maps leftward movement (negative
distX) to"right"and rightward movement (positivedistX) to"left", so the back gesture fires on the wrong swipe.Apply this diff to swap the labels:
- const dir = distX < 0 ? "right" : "left";+ const dir = distX < 0 ? "left" : "right";
🧹 Nitpick comments (1)
infrastructure/eid-wallet/src/routes/+layout.svelte (1)
441-444: Consider edge-case interference with scrolling.Attaching swipe detection to the entire scrollable main wrapper may conflict with vertical scrolling or text selection on some devices. If users report issues, consider:
- Detecting swipes only from the screen edge
- Adding more restrictive thresholds
- Excluding swipes that begin on interactive elements
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
infrastructure/eid-wallet/src/lib/utils/index.ts(1 hunks)infrastructure/eid-wallet/src/lib/utils/swipeGesture.ts(1 hunks)infrastructure/eid-wallet/src/routes/+layout.svelte(4 hunks)
🔇 Additional comments (5)
infrastructure/eid-wallet/src/lib/utils/index.ts (1)
4-4: LGTM!The export statement correctly re-exports the swipeGesture module.
infrastructure/eid-wallet/src/routes/+layout.svelte (2)
10-10: LGTM!The import statement correctly brings in the swipedetect utility.
20-20: LGTM!The state variable is correctly typed for element binding.
infrastructure/eid-wallet/src/lib/utils/swipeGesture.ts (2)
6-13: LGTM!The threshold values are reasonable for detecting intentional swipe gestures while filtering out accidental touches.
15-24: LGTM!The
touchstarthandler correctly captures the initial touch position and timestamp.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description of change
Back gesture added
Issue Number
closes#406
Type of change
How the change has been tested
Manual
Change checklist
Summary by CodeRabbit