Uh oh!
There was an error while loading. Please reload this page.
chore: force signing modal - #456
Merged
Merged
Conversation
Contributor
Caution Review failedThe pull request is closed. WalkthroughThe PR integrates a real-time signing flow into the reference modal component. After reference submission, if a signing session is provided by the server, the modal initiates an SSE connection to monitor signing progress, displays a QR code or deep link for mobile users, manages session expiry with a countdown timer, and conditionally renders UI based on signing status. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Modal as Reference Modal
participant Server
participant SSE as SSE Stream
participant Cache as Invalidation Cache
User->>Modal: Submit Reference Form
Modal->>Server: Create Reference + Request Signing Session
Server->>Modal: Return signingSession (id, QR, expiry)
rect rgb(230, 240, 250)
Note over Modal: Initialize Signing State
Modal->>Modal: Set signingStatus = "connecting"
Modal->>Modal: Render QR Code / Deep Link
Modal->>Modal: Start 15-min Countdown Timer
end
Modal->>SSE: Establish SSE Connection (sessionId)
SSE->>Modal: Monitor for Signing Events
rect rgb(240, 250, 240)
Note over SSE,Cache: Signing Complete Path
SSE->>Modal: "signed" Event
Modal->>Modal: Set signingStatus = "signed"
Modal->>Cache: Invalidate Reference Cache
Modal->>User: Success Toast
Modal->>Modal: Close Modal (after delay)
end
rect rgb(250, 240, 240)
Note over SSE,Modal: Error Paths
alt Session Expired
SSE->>Modal: "expired" Event
Modal->>Modal: Set signingStatus = "expired"
else Security Violation
SSE->>Modal: "security_violation" Event
Modal->>Modal: Set signingStatus = "security_violation"
end
Modal->>User: Error Indicator + Try Again Button
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coodos
marked this pull request as ready for review
November 21, 2025 08:00
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 21, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.