feat: requested UI and UX improvements - #524

Merged
coodos merged 1 commit into
mainfrom
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged

feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom
fix/e-currency-ui-ux-fixes

Conversation

@coodos

@coodoscoodos commented Dec 8, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description of change

UI/UX improvements

Issue Number

closes#520

Type of change

  • Update (a change which updates existing functionality)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

Release Notes

  • New Features

    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.

  • Bug Fixes

    • Fixed user menu dropdown to properly display the current account name.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Dec 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.

Changes

Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.

Sequence Diagram

sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components

Suggested reviewers

  • ananyayaya129
  • sosweetham

Poem

🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.

📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos
coodos marked this pull request as ready for review December 8, 2025 16:27
@coodos
coodos merged commit 71d2336 into mainDec 8, 2025
3 of 4 checks passed
@coodos
coodos deleted the fix/e-currency-ui-ux-fixes branch December 8, 2025 16:28
This was referenced Dec 9, 2025
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements

2 participants

@coodos@kulmin
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: requested UI and UX improvements - #524
Merged
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Dec 8, 2025
Merged
feat: requested UI and UX improvements#524
coodos merged 1 commit into
mainfrom 
fix/e-currency-ui-ux-fixes
Conversation
@coodos
@coodoscoodos
commented
Dec 8, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description of change
UI/UX improvements
Issue Number
closes#520
Type of change
  • Update (a change which updates existing functionality)
How the change has been tested
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
Release Notes
  • New Features
    • Added total currency supply information displayed on currency detail pages.
    • Introduced "Negative Balance Allowed" / "No Negative" indicators on dashboard and currency detail cards.
  • Bug Fixes
    • Fixed user menu dropdown to properly display the current account name.
✏️ Tip: You can customize this high-level summary in your review settings.
@coderabbitai
coderabbitaiBot
commented
Dec 8, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
The pull request is closed.
Walkthrough
Added a backend endpoint and service method to calculate total currency supply by aggregating account balances. Enhanced frontend UI to display total supply, indicate whether negative balances are allowed, and show the current account context (user or group) in the top menu.
Changes
Cohort / File(s)Summary
Backend Ledger API
platforms/eCurrency-api/src/controllers/LedgerController.ts, platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/services/LedgerService.ts		Added getTotalSupply(currencyId) endpoint with authentication guard. Fetches all distinct account/accountType pairs for a currency, retrieves each balance, and returns the summed total. Added allowNegative field mapping to balance listings.
User Context Display
platforms/eCurrency/client/src/components/user-menu-dropdown.tsx		Fixed prop name from onAccountContextChang to onAccountContextChange. Updated display label to show "Currently managing: {currentAccountName}" with logic to derive account name from user/group context.
Currency Detail & Dashboard UI
platforms/eCurrency/client/src/pages/currency-detail.tsx, platforms/eCurrency/client/src/pages/dashboard.tsx		Added data fetch for total currency supply via /api/ledger/total-supply/{currencyId}. Renders "Negative Balance Allowed" indicator (Yes/No with color coding) and total supply value. Dashboard shows inline badge ("Negative Allowed" or "No Negative") on each currency card.
Sequence Diagram
sequenceDiagram
participant User
participant Client as Client (Browser)
participant Server as API Server
participant DB as Database
User->>Client: Navigate to currency detail
Client->>Server: GET /api/ledger/total-supply/:currencyId
Note over Server: Authenticate request
Server->>DB: Query distinct accounts for currency
DB-->>Server: [accountId, accountType] pairs
loop For each account
Server->>DB: Get balance for account
DB-->>Server: balance
Note over Server: Accumulate total
end
Server-->>Client: { currencyId, totalSupply }
Client->>Client: Render total supply & allowNegative badge
Client-->>User: Display currency details with supply & balance rules

Loading
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Backend service logic: getTotalSupply aggregation loop requires verification of query correctness and balance accumulation
  • Prop name fix: Potential breaking changes—verify all callers of UserMenuDropdown use updated prop name
  • Data fetching integration: Ensure query key and endpoint alignment; check loading state handling
  • UI rendering logic: Verify conditional rendering of badges and supply display across multiple components
Suggested reviewers
  • ananyayaya129
  • sosweetham
Poem
🐰 Hop hop, the supply's now clear,
Total counts ring loud and dear,
Badges bloom where balances show,
Context switches—watch us grow!
Ledgers dance, accounts align,
A feature complete, carrots divine! 🥕✨
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch fix/e-currency-ui-ux-fixes
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 849c36f and b372c5d.
📒 Files selected for processing (6)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (2 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (2 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@coodos
coodos
marked this pull request as ready for review
December 8, 2025 16:27
@coodos
coodos
merged commit 71d2336
into
mainDec 8, 2025

3 of 4 checks passed

@coodos
coodos
deleted the

fix/e-currency-ui-ux-fixes

branch
December 8, 2025 16:28

This was referenced Dec 9, 2025
 Merged

 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kulminkulminkulmin approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[feature] eCurrency UI Improvements


2 participants

@coodos@kulmin