Uh oh!
There was an error while loading. Please reload this page.
chore: minor improvments - #591
Conversation
WalkthroughThis PR updates character limits for reference text input from 500 to 5000 characters across validation and UI display, and modifies default sorting behavior in the eVoting platform from deadline-based ascending order to creation-date-based descending order across frontend and backend components. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
platforms/eReputation/client/src/components/modals/reference-modal.tsx (2)
318-325: 5000‑char validation and messaging look consistent; consider de‑duplicating the magic numberThe new
referenceText.length > 5000check and the toast message line up with themaxLengthand counter below. To reduce drift if this ever changes again, consider extracting5000into a sharedMAX_REFERENCE_LENGTHconstant and reusing it in the validation, toast copy,maxLength, and the counter text.
581-585:> 5000threshold is unreachable withmaxLength={5000}Because the
TextareaenforcesmaxLength={5000},referenceText.lengthwill never exceed 5000 via normal UI input, so the"text-apple-red"branch in the counter will not be hit. If you want a visual warning near the limit, consider switching to a lower threshold (e.g. 0.9 * max) or using>=and slightly loweringmaxLength.platforms/eVoting/src/app/(app)/page.tsx (1)
22-25: Front‑end sort defaults correctly switched to createdAt/DESC; consider whether to surface this in the UIInitializing
sortFieldto"createdAt"andsortDirectionto"desc"(with localStorage overrides) keeps the client in sync with the API’s new defaults and naturally promotes the newest polls. Since there’s no column keyed as"createdAt", the initial sort won’t show a sort icon on any header; if you ever want users to see the default ordering explicitly, you might map one of the existing columns (e.g. Deadline or a new “Created” column) to"createdAt"for the sort icon only.Also applies to: 28-31
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
platforms/eReputation/client/src/components/modals/reference-modal.tsx(2 hunks)platforms/eVoting/src/app/(app)/page.tsx(1 hunks)platforms/evoting-api/src/controllers/PollController.ts(1 hunks)platforms/evoting-api/src/services/PollService.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
platforms/eReputation/client/src/components/modals/reference-modal.tsx (1)
platforms/eReputation/client/src/hooks/use-toast.ts (1)
toast(191-191)
platforms/evoting-api/src/services/PollService.ts (1)
platforms/eVoting/src/lib/pollApi.ts (1)
Poll(3-26)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
platforms/evoting-api/src/controllers/PollController.ts (1)
16-17: API sort defaults now align with service and UI (createdAt/DESC)Using
"createdAt"with"desc"as fallbacks here matches thePollService.getAllPollsdefaults and the eVoting frontend, so new polls will surface first even when the client omits sort parameters.platforms/evoting-api/src/services/PollService.ts (1)
21-21: New createdAt/DESC default and sort branch are consistent and correctThe updated
getAllPollssignature defaults (sortField = "createdAt",sortDirection = "desc") and the new"createdAt"switch case (new Date(...).getTime()diff + direction flip) correctly implement “newest first” as the base behavior. This lines up withPollController.getAllPollsand the eVoting Home page defaults, so ordering is now coherent across API and UI.Also applies to: 116-118
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.