fix: prevent Safari iOS 16 crash in charter flow - #661

Merged
coodos merged 1 commit into
mainfrom
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged

fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom
fix/safari-ios-16-crash-group-charter

Conversation

@Bekiboo

@BekibooBekiboo commented Jan 7, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description of change

Fixes a UI crash on Safari iOS 16 when opening the Charter.

  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets

This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.

Issue Number

Closes#636

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Changes not tested yet

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.

  • Chores

    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.

✏️ Tip: You can customize this high-level summary in your review settings.

@BekibooBekiboo self-assigned this Jan 7, 2026
@coderabbitai

coderabbitaiBot commented Jan 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.

Changes

Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.

Suggested reviewers

  • coodos

Poem

🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Bekiboo
Bekiboo marked this pull request as ready for review January 7, 2026 19:09
@Bekiboo
Bekiboo requested a review from coodos as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot reviewed Jan 7, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)

1-8: Minor comment inconsistency with actual targets.

The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.

📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.

📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)

3-3: LGTM! Standard Next.js typed routes feature.

This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.

platforms/group-charter-manager/next.config.ts (1)

8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.

The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.

Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:

  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)

20-24: [Rewritten comment]
[Classification tag]

sosweetham
sosweetham approved these changes Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />

@sosweethamsosweethamJan 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh

@sosweetham

sosweetham commented Jan 13, 2026

Copy link
Copy Markdown
Member

nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄

@coodos
coodos merged commit 7b4a274 into mainJan 15, 2026
4 checks passed
@coodos
coodos deleted the fix/safari-ios-16-crash-group-charter branch January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”

3 participants

@Bekiboo@sosweetham@coodos
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: prevent Safari iOS 16 crash in charter flow - #661
Merged
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Jan 15, 2026
Merged
fix: prevent Safari iOS 16 crash in charter flow#661
coodos merged 1 commit into
mainfrom 
fix/safari-ios-16-crash-group-charter
Conversation
@Bekiboo
@BekibooBekiboo
commented
Jan 7, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Description of change
Fixes a UI crash on Safari iOS 16 when opening the Charter.
  • Removed a hardcoded http://localhost fallback causing mixed-content errors in production
  • Transpiled markdown-related client dependencies to avoid unsupported RegExp syntax in Safari 16
  • Added browserslist config to define supported Safari/iOS targets
This prevents JS execution from failing and keeps the Charter flow usable on iOS 16.
Issue Number
Closes#636
Type of change
  • Fix (a change which fixes an issue)
How the change has been tested
Changes not tested yet
Change checklist
  •  I have ensured that the CI Checks pass locally
  •  I have removed any unnecessary logic
  •  My code is well documented
  •  I have signed my commits
  •  My code follows the pattern of the application
  •  I have self reviewed my code
Summary by CodeRabbit
  • New Features
    • Maintenance banner notifications can now be dismissed and remain dismissed during your session.
  • Chores
    • Updated browser compatibility targets to support Safari 16+, iOS 15+, and other modern browsers.
    • Enhanced compatibility with markdown processing libraries.
✏️ Tip: You can customize this high-level summary in your review settings.
@BekibooBekiboo
self-assigned this
Jan 7, 2026
@coderabbitai
coderabbitaiBot
commented
Jan 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Browser compatibility and transpilation settings are configured for Safari 16+ support. Next.js environment types are updated. The MaintenanceBanner component is corrected to properly fetch and display maintenance status data on mount.
Changes
Cohort / File(s)Summary
Browser & Build Configuration
platforms/group-charter-manager/.browserslistrc, platforms/group-charter-manager/next-env.d.ts, platforms/group-charter-manager/next.config.ts		Added browserslist targets (iOS ≥15, Safari ≥15, last 2 versions). Added TypeScript reference to Next.js route types. Added transpilePackages config for 'marked' and '@milkdown/preset-gfm' to ensure Safari 16 compatibility.
MaintenanceBanner Component Fix
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx		Added isDismissed state. Modified fetchMotd to require NEXT_PUBLIC_REGISTRY_URL (no fallback) with early return guard. Fixed useEffect to invoke fetchMotd on mount. Updated status string comparisons to use double quotes.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • feat: motd #361: Introduces the MOTD endpoint and maintenance-banner behavior that this PR fully integrates into the component.
  • feat: dismissible banner #364: Modifies the same MaintenanceBanner component with state management and localStorage handling for banner dismissal.
Suggested reviewers
  • coodos
Poem
🐰 Browser walls now built so tall,
Safari's gap shall not enthrall,
Transpiled packages, strong and fleet,
iOS sixteen—now complete!
Maintenance signals, loud and clear, 🌟
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main fix: preventing Safari iOS 16 crashes in the charter flow, which is the primary objective of this PR.
Description check✅ PassedThe PR description includes all required sections: change summary, issue number, type of change, testing notes, and completed checklist items.
Linked Issues check✅ PassedThe code changes address all key objectives from #636: removed hardcoded localhost fallback, transpiled markdown packages for Safari 16 RegExp compatibility, and added browserslist config for browser targets.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the iOS 16 Safari crash: browserslist config, next-env types, transpilePackages in next.config, and MaintenanceBanner localhost fallback removal.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
  •  📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@Bekiboo
Bekiboo
marked this pull request as ready for review
January 7, 2026 19:09
@Bekiboo
Bekiboo
requested a review
from coodos
as a code ownerJanuary 7, 2026 19:09
coderabbitai[bot]
coderabbitaiBot
reviewed
Jan 7, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Nitpick comments (1)
platforms/group-charter-manager/.browserslistrc (1)
1-8: Minor comment inconsistency with actual targets.
The comment mentions "iOS 16+ Safari support" but the configuration targets iOS >= 15 and Safari >= 15. While this includes iOS 16, the comment could be more accurate to reflect the broader support range being configured.
📝 Suggested clarification
 # Browsers that we support
-# iOS 16+ Safari support+# iOS 15+ and Safari 15+ support (includes iOS 16 fix)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 0144c4d and 77bf885.
📒 Files selected for processing (4)
  • platforms/group-charter-manager/.browserslistrc
  • platforms/group-charter-manager/next-env.d.ts
  • platforms/group-charter-manager/next.config.ts
  • platforms/group-charter-manager/src/components/MaintenanceBanner.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
platforms/group-charter-manager/next-env.d.ts (1)
3-3: LGTM! Standard Next.js typed routes feature.
This reference enables type-safe routing in Next.js 15+, which is appropriate for your Next.js 15.5.9 installation.
platforms/group-charter-manager/next.config.ts (1)
8-12: Verify the transpilation fixes Safari 16 RegExp errors on a Safari iOS 16 device or simulator.
The approach of using transpilePackages is correct for addressing Safari 16 compatibility issues. Both marked (v16.1.1) and @milkdown/preset-gfm (v7.15.2) are used in the codebase and will be transpiled to avoid unsupported RegExp syntax. The configuration is properly set up in next.config.ts.
Since the PR description notes that "changes have not been tested yet," manual verification on an actual Safari iOS 16 device or simulator is required to confirm:
  1. The "Invalid regular expression: invalid group specifier name" error no longer occurs
  2. The Charter flow opens and functions correctly
  3. No ChunkLoadError is thrown
platforms/group-charter-manager/src/components/MaintenanceBanner.tsx (1)
20-24: [Rewritten comment]

[Classification tag]
sosweetham
sosweetham
approved these changes
Jan 13, 2026
View reviewed changes
Comment threadplatforms/group-charter-manager/next-env.d.ts
@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference path="./.next/types/routes.d.ts" />
@sosweethamsosweethamJan 13, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be ignored tbh
@sosweetham
sosweetham
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
nothing has changed but worked fine in ios 16 xcode virtual device for me lol 😄
@coodos
coodos
merged commit 7b4a274
into
mainJan 15, 2026

4 checks passed

@coodos
coodos
deleted the

fix/safari-ios-16-crash-group-charter

branch
January 15, 2026 15:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@sosweethamsosweethamsosweetham approved these changes
@coodoscoodosAwaiting requested review from coodoscoodos is a code owner

Assignees

@BekibooBekiboo

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Bug] [iOS 16][Safari] UI breaks after clicking “View Charter”


3 participants

@Bekiboo@sosweetham@coodos