Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix/esigner and ereference issues - #736

Merged
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits into
mainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos

@coodoscoodos commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes#641
closes#640
closes#694
closes#693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s)Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made.Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check✅ PassedThe PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check✅ PassedAll code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

Comment threadplatforms/evoting-api/src/services/MessageService.ts
@coodos
coodos merged commit 2c10242 into mainJan 28, 2026
4 checks passed
@coodos
coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes
* fix: UTC time instead of local
* fix: UTC time explicitly set at backend
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@coodos@sosweetham