Uh oh!
There was an error while loading. Please reload this page.
feat: implement Trust Score Service with scoring algorithm and API enpoints - #810
Conversation
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA new Trust Score Service was added: an Express app exposing health and trust-score endpoints, a deterministic 0–10 scoring module, mocked user-data fetchers (with TODOs for real APIs), unit tests, package/config files, and README documentation. (50 words) Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ExpressAPI as Express API
participant UserData as UserDataService
participant Score as ScoreCalculator
Client->>ExpressAPI: GET /trust-score/:eName
ExpressAPI->>UserData: fetchUserTrustData(eName)
par parallel fetches
UserData->>UserData: fetchVerificationStatus(eName)
UserData->>UserData: fetchAccountAgeDays(eName)
UserData->>UserData: fetchKeyLocation(eName)
UserData->>UserData: fetchThirdDegreeConnections(eName)
end
UserData-->>ExpressAPI: { isVerified, accountAgeDays, keyLocation, thirdDegreeConnections }
ExpressAPI->>Score: calculateTrustScore(userData)
Score-->>ExpressAPI: { score, breakdown }
ExpressAPI-->>Client: { eName, score, breakdown }
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@platforms/blabsy/next-env.d.ts`:
- Around line 1-6: The file next-env.d.ts is an auto-generated Next.js artifact
and should not be committed; remove next-env.d.ts from the PR (unstage/remove it
from the commit or revert the added file) and add an entry for next-env.d.ts to
the package's .gitignore (the .gitignore in the same package where the file
lives) so it is ignored in future commits.
In `@services/trust-score/src/index.js`:
- Around line 118-139: The GET handler for app.get("/trust-score") lets negative
accountAgeDays and thirdDegreeConnections through (Number(req.query...) || 0
yields negatives), so add the same non-negative validation used in the POST:
after parsing accountAgeDays and thirdDegreeConnections, check they are >= 0 and
if not return a 400 JSON error (matching the POST behavior). Keep the existing
keyLocation validation and still call calculateTrustScore only after the
non-negative checks pass.
- Around line 141-145: The module currently starts the HTTP server at import
time because app.listen(PORT, ...) is invoked alongside module.exports = app;
change this so importing the module doesn't create side effects: remove the
top-level app.listen call and instead guard it so the server only starts when
the file is executed directly (e.g. wrap the app.listen invocation in a
require.main === module check or expose a startServer/start function and call it
from a separate entrypoint). Update references to PORT and app.listen
accordingly and keep module.exports = app for tests.
🧹 Nitpick comments (1)
services/trust-score/src/userDataService.js (1)
99-109: Consider adding error handling when wiring real API calls.Currently the mocks can't fail, but once real HTTP calls replace them, a single failing fetcher in
Promise.allwill reject the entire aggregation with no indication of which data source failed. When you replace the mocks, consider wrapping individual fetchers or usingPromise.allSettledwith fallback defaults so partial failures are identifiable and recoverable.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…nnections in GET endpoint
Description of change
Issue Number
Advances #788
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Documentation
Tests