Uh oh!
There was an error while loading. Please reload this page.
update [eid-wallet]: text changes proposed by Egor - #897
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR makes presentation and copy edits across five eID Wallet Svelte pages: reflowing markup, adjusting viewport and sizing classes, refining button handler formatting, and updating user-facing text and error messages. No exported signatures, control flow, data fetching, or event-handling semantics are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@infrastructure/eid-wallet/src/routes/`(app)/ePassport/+page.svelte:
- Line 681: Remove the stray "²" character from the +page.svelte template in the
ePassport route; locate the unexpected character in the component's markup
(outside <script> tags) and delete it so it no longer renders in the UI, and
verify there are no similar stray characters elsewhere in the same file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bff50f4e-db5e-485d-a87c-33f7983bab2e
📒 Files selected for processing (5)
infrastructure/eid-wallet/src/routes/(app)/ePassport/+page.svelteinfrastructure/eid-wallet/src/routes/(app)/main/+page.svelteinfrastructure/eid-wallet/src/routes/(auth)/e-passport/+page.svelteinfrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelteinfrastructure/eid-wallet/src/routes/(auth)/register/+page.svelte
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
infrastructure/eid-wallet/src/routes/(app)/ePassport/+page.svelte (1)
753-756: Prefer avoiding hard<br />in user copy.Using a manual line break can make localization and responsive text flow harder; prefer separate text blocks/styling.
♻️ Suggested copy layout tweak
- <p class="text-black-700">- Ask a trusted person with an eID Wallet to scan this QR and- confirm it’s you. <br />- They will sign a social binding for your Digital Self – no access- to your data.- </p>+ <p class="text-black-700">+ Ask a trusted person with an eID Wallet to scan this QR and+ confirm it’s you.+ </p>+ <p class="text-black-700 mt-2">+ They will sign a social binding for your Digital Self – no access+ to your data.+ </p>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@infrastructure/eid-wallet/src/routes/`(app)/ePassport/+page.svelte around lines 753 - 756, The user-facing copy currently uses a hard <br /> in the +page.svelte template; replace that manual line break with semantic/structure-based markup (e.g., split into two paragraphs or two spans inside a containing element) and control spacing with CSS classes instead of <br /> so text can reflow and be localized easily; locate the text block in +page.svelte (the ePassport page text near the QR instructions) and split it into separate text nodes/elements with appropriate styling.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@infrastructure/eid-wallet/src/routes/`(app)/ePassport/+page.svelte:
- Around line 753-756: The user-facing copy currently uses a hard <br /> in the
+page.svelte template; replace that manual line break with
semantic/structure-based markup (e.g., split into two paragraphs or two spans
inside a containing element) and control spacing with CSS classes instead of <br
/> so text can reflow and be localized easily; locate the text block in
+page.svelte (the ePassport page text near the QR instructions) and split it
into separate text nodes/elements with appropriate styling.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 92f20b55-1fe6-41a4-9fcc-0c7c7bea0f4a
📒 Files selected for processing (1)
infrastructure/eid-wallet/src/routes/(app)/ePassport/+page.svelte
coodos
approved these changes
Mar 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Adjusted text in eID Wallet as proposed by Egor
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit