Uh oh!
There was an error while loading. Please reload this page.
feat: names of people on control panel - #900
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe pull request adds ontology-based identity resolution to determine user vs. group types for eVaults and implements a platform token workflow. The UI is updated to display real names with corresponding user/group icons, while the API endpoint now fetches vault identities from metadata envelopes and acquires platform tokens for secure registry access. Changes
Sequence DiagramsequenceDiagram
participant Client as Control Panel Client
participant API as API Endpoint
participant Registry as Registry Service
participant Token as Platform Token Service
participant Ontology as Ontology/Metadata Service
Client->>API: GET /api/evaults
API->>Token: Request platform token
Token->>Registry: Authenticate and issue token
Registry-->>Token: Platform token
Token-->>API: Return token
API->>Registry: Fetch all vaults (with token)
Registry-->>API: Vault list
loop For each vault
API->>Ontology: Fetch parsed metadata from metaEnvelopes
Ontology-->>API: GraphQL response with identity data
API->>API: Resolve identity (type, name)
API->>API: Perform health check
end
API-->>Client: EVaults with real names and types
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@infrastructure/control-panel/src/routes/api/evaults/`+server.ts:
- Around line 136-140: The GET route currently treats
requestPlatformToken(platform) failures as fatal; change the GET RequestHandler
so that token acquisition is optional — catch errors from requestPlatformToken
(both at the first call and the later call around lines ~178-180) and log the
error but continue execution, using registryService.getEVaults() results as the
primary response; if the token is obtained use it to enrich the evaults,
otherwise return evaults from registryService.getEVaults() (and avoid throwing a
500 when requestPlatformToken fails).
- Around line 47-53: The code is directly forwarding the platform bearer token
to untrusted registry-provided endpoints by calling
fetch(`${vault.uri}/graphql`, ...) with Authorization: `Bearer ${token}`;
instead, validate vault.uri against a trusted allowlist or a registry flag
before attaching Authorization, or route the metadata/graphql request through a
trusted backend proxy that injects the token server-side. Locate the fetch call
that uses vault.uri and token in +server.ts and change the logic so that
Authorization is only set for known/trusted vault origins (or remove it for
unverified URIs), or implement a backend proxy endpoint that performs the
authenticated request to vault.uri and returns sanitized results to the SSR
handler.
- Around line 24-25: The identity type field currently narrows to 'user' |
'group' and so silently mislabels unresolved lookups; change the type union to
include a neutral fallback (e.g. type: 'user' | 'group' | 'unknown') in the
affected identity/interface definition, update the resolver path that sets the
type to return 'unknown' when both ontology lookups miss or time out, and adjust
any downstream checks (places referenced in the same file around the resolver
logic at lines ~84-110) to explicitly handle 'unknown' rather than assuming
'group'. Ensure the ename field stays unchanged and only the type fallback is
added so consumers can detect and treat unresolved identities safely.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 041b7a21-b7f4-4123-be24-028785209506
📒 Files selected for processing (2)
infrastructure/control-panel/src/routes/+page.svelteinfrastructure/control-panel/src/routes/api/evaults/+server.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
closes#782
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Improvements