Uh oh!
There was an error while loading. Please reload this page.
Feat/control panel login and access management - #903
Merged
Conversation
Contributor
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR implements a complete W3DS-based authentication system for the control panel, including session management, JWT token generation, admin allowlist validation, and updated UI/layouts to support user authentication and logout functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client (Browser)
participant LayoutSvelte as Layout Component
participant AuthAPI as /api/auth Endpoint
participant Registry as Registry (Signature Verification)
participant SessionStore as Session Store
participant AllowList as Admin AllowList
participant CookieJar as Cookie Storage
Client->>LayoutSvelte: Navigate to /login (unauthenticated)
LayoutSvelte->>AuthAPI: GET /api/auth/offer
AuthAPI->>SessionStore: createAuthSession()
SessionStore-->>AuthAPI: sessionId
AuthAPI-->>LayoutSvelte: {uri, sessionId, expiresInMs}
LayoutSvelte->>LayoutSvelte: Generate QR code from uri
LayoutSvelte->>LayoutSvelte: Establish SSE to /api/auth/sessions/[id]
Client->>Client: Scan QR with W3DS wallet
Client->>AuthAPI: POST /api/auth with signature
AuthAPI->>SessionStore: consumeAuthSession(id)
SessionStore-->>AuthAPI: valid/invalid
AuthAPI->>Registry: Verify signature
Registry-->>AuthAPI: Valid/Invalid
AuthAPI->>AllowList: isAdminEName(ename)
AllowList-->>AuthAPI: true/false
AuthAPI->>SessionStore: publishAuthSessionResult(id, {status, ename})
SessionStore-->>LayoutSvelte: SSE data (success)
AuthAPI-->>Client: {ok, ename} or error
LayoutSvelte->>AuthAPI: POST /api/auth/complete with sessionId
AuthAPI->>SessionStore: getAuthSessionResult(sessionId)
SessionStore-->>AuthAPI: {status: 'success', ename}
AuthAPI->>AuthAPI: signAuthToken({ename})
AuthAPI->>CookieJar: Set auth cookie (HttpOnly, Secure)
AuthAPI-->>LayoutSvelte: {ok: true, ename}
LayoutSvelte->>LayoutSvelte: Redirect to /
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
closes#783
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Documentation