Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Add extra logging for debugging 500 responses *not for dev branch* - #2075
Merged
Conversation
added 2 commits
January 12, 2018 15:05
rkday-pro
commented
Jan 12, 2018
Contributor
Looks good as far as it goes. But: Think the bgcfsproutlet.cpp, hss_sip_mapping.cpp and maybe basicproxy.cpp are worth looking at if you haven't already. |
br1-msw
commented
Jan 12, 2018
ContributorAuthor
hss_sip_mapping/basicproxy already has a TRC_ERROR logs, and bgcfsproutlet TRC_WARNING so should already come out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rkd-msw please sanity check that these are sensible checks. I don't think there are other sproutlets we can hit this on.