chore: make ach debit daily report readable only to match octo

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];

[srikar-methodfi]

make ach debit daily report readable only to match octo

[Copilot]

Pull request overview

This PR narrows the set of report type values that can be used with POST /reports so that ach.debit.daily is treated as read-only (retrievable/downloadable but not creatable), aligning behavior with “octo”.

Changes:

• Introduces ReportCreateTypes / TReportCreateTypes and updates IReportCreateOpts.type to only allow creatable report types.
• Leaves ach.debit.daily in ReportTypes / IReport.type so it remains readable.
• Adds TypeScript compile-time assertions in the report tests to enforce “readable but not creatable”.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
test/resources/Report.tests.ts	Adds type-level assertions validating ach.debit.daily remains readable but is not creatable.
src/resources/Report/index.ts	Splits “all report types” vs “creatable report types” by introducing ReportCreateTypes and narrowing IReportCreateOpts.type.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/resources/Report/index.ts:26

• ReportTypes.ach_debit_daily was removed, which is a breaking API change for any downstream code that referenced this exported constant. If the goal is only to prevent creation while still allowing consumers to reference the type for retrieval, consider preserving a deprecated alias (or introducing a dedicated ReportCreateTypes constant/type for creatable reports) instead of removing the key from ReportTypes.

export const ReportRetrieveTypes = {
...ReportTypes,
ach_debit_daily: 'ach.debit.daily',
} as const;
export type TReportRetrieveTypes = typeof ReportRetrieveTypes[keyof typeof ReportRetrieveTypes];