Uh oh!
There was an error while loading. Please reload this page.
adding update capabilities for classification nodes - #470
Conversation
a11smiles
commented
Jul 1, 2022
@SebastianSchuetze can you run the workflows please? I had a mistype in my unit tests. Thanks! |
SebastianSchuetze
commented
Jul 2, 2022
looks like you have green lights. I will review in the next few days. |
SebastianSchuetze
left a comment
There was a problem hiding this comment.
Please check the comments. Nothing serious. Otherwise I will approve as soon as I understand or changes are made. :-)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Sorry forgot to save my other suggestions @a11smiles :-)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SebastianSchuetze
commented
Jul 25, 2022
@a11smiles anything I can help with to get this PR finished? |
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
a11smiles
commented
Aug 3, 2022
I wasn't sure how particular you guys were with 'return' vs. 'update'. Thanks for making the changes. |
SebastianSchuetze
left a comment
There was a problem hiding this comment.
All good now, thanks!
PR Summary
For the second bullet, consider the following scenario:
In a situation where I'm syncing two projects (e.g. copying iterations from one to another), the current implementation would require me to write the following
if-elsestatement to check if dates are provided because it doesn't allow for a nullable DateTime.Not allowing a nullable DateTime is okay if the node is net new. However, I have the write this
if-elsefor pre-existing nodes when attempting to simply copy them.[Add|Update]-VSTeamIteration
Params changed to the following:
This also removes the need for these
ifstatements. (Also, AzDO requires that if one date is set, the other MUST also be set. It won't allow a StartDate and not a FinishDate, and vice versa.)By making the above changes, I no longer need my original
if-elsestatement. I can simply write the following one line and the null values are accepted.PR Checklist