Fix disappearing cover images when the file is missing from S3 - #623
Merged
Merged
Conversation
When an image field references a file missing from S3, sorl-thumbnail returns a sizeless placeholder instead of None, causing `im.width` to raise TypeError. sorl already recovers from that by rendering the tag's `{% empty %}` clause, but none of our templates defined one, so covers silently vanished instead of falling back to the existing "image not found" placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sorl-thumbnail'sget_thumbnail()returns a sizeless placeholder object (notNone) when the source file is missing from S3, so{{ im.width }}raisedTypeError: 'NoneType' object is not subscriptable. sorl already recovers from that by rendering the{% thumbnail %}tag's{% empty %}clause, but none of our templates defined one — so the cover silently vanished instead of showing the existing "image not found" placeholder, and the log filled with stacked tracebacks per occurrence.{% empty %}clauses (reusing each template's existing fallback markup) to every{% thumbnail %}block acrosscomicsdb,reading_lists,user_collection, anduserstemplates.