Drop unused issue_count field from pull_list series serializer - #626
Merged
Merged
Conversation
PullListSeriesInfoSerializer exposed issue_count, sourced from num_issues via the inherited SeriesListSerializer field. num_issues is only ever populated by a queryset annotation done elsewhere (SeriesViewSet), and PullListViewSet.series() never added it. Since the field is read_only, DRF silently skipped it rather than erroring, so it was always missing from the response despite being documented. Remove it rather than adding a redundant annotation just for this list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PullListSeriesInfoSerializerexposedissue_count, sourced fromnum_issuesvia the inheritedSeriesListSerializerfieldnum_issuesis only ever populated by a queryset annotation done elsewhere (SeriesViewSet);PullListViewSet.series()never added itread_only, DRF silently skips it rather than erroring, so it was always missing fromGET /api/pull_list/series/responses despite being in the field list and documented in the READMEFixed #625