bug: widespread key={index} on lists that have stable identifiers

[nanaf6203-bit]

Summary

Lists in many components use key={index} for items that already have stable identifiers.

Affected area

• src/components/mobile/OfflinePropertyCache.tsx (cached properties — has id)
• src/components/mobile/MobilePropertyViewer.tsx (thumbnails)
• src/components/mobile/MobilePropertyCard.tsx (badges)
• src/components/property/ImageLightbox.tsx
• src/components/audit/TransactionAuditTrail.tsx
• src/components/search/SearchHistoryDropdown.tsx
• src/components/LoadingSpinner.tsx
• src/components/security/WalletAddressInput.tsx (errors/warnings)
• src/components/responsive/ImagePlaceholder.tsx
• src/components/responsive/LazyLoadingExample.tsx
• src/components/TransactionConfirmation.tsx / src/components/SecureTransactionConfirmation.tsx
• src/components/dashboard/\*

Steps to reproduce / impact

When the underlying list changes (filter change, delete item, reorder), React destroys and rebuilds DOM nodes, losing focus and animation state. Image lightboxes flicker. Loading states lose progress.

Expected behaviour

Use a stable identifier (id, hash, src, …) as the key wherever one exists. Resort to key={index} only as a last resort for lists with no inherent identity.

Acceptance criteria

• Replace key={index} in all the files above with stable identifiers.
• Add a lint rule (or comment) prohibiting key={index} for elements that have a meaningful id.
• Open a follow-up tracking remaining offenders.

[Akinyemi04]

@Akinyemi04 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Akinyemi04 to this issue.

[JamesEjembi]

@JamesEjembi has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

i would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @JamesEjembi to this issue.

[drips-wave]

Congratulations, @JamesEjembi! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @JamesEjembi: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @JamesEjembi as part of the Stellar Wave Program's 6th Wave 🥳

😎 @JamesEjembi: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.