Skip to content

bug: inconsistent modal focus management and ARIA roles #437

Description

@nanaf6203-bit

Summary

PageTransition.tsx modal wrappers do not trap focus, do not restore focus on close, and have inconsistent ARIA roles across modal types.

Affected area

  • src/components/PageTransition.tsx
  • src/components/ui/dialog.tsx
  • Modals: WalletModal, TransactionProgress, TransactionDetailsModal, TransactionConfirmation, etc.

Steps to reproduce / impact

Keyboard users get trapped or, conversely, exit the modal without focus returning. Inconsistent ARIA roles means screen readers intermittently ignore the dialog.

Expected behaviour

Adopt a single <Dialog> primitive (Radix UI is already a dependency) for every modal. Disable body scroll, trap focus, return focus on close, expose aria-modal and aria-labelledby.

Acceptance criteria

  • Replace ad-hoc modal markup with Radix Dialog across the app.
  • Add Playwright test asserting focus is trapped and restored.
  • axe-core has zero modal violations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programaccessibilityAccessibility (a11y) issuebugSomething isn't working correctlypriority/p2P2 — medium priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions