Skip to content

security: rate-limit phishing detection lookups #446

Description

@nanaf6203-bit

Summary

Phishing detection in src/utils/security/phishingProtection.ts runs synchronously per navigation. Calling PhishingProtection.detectPhishing on every render or every navigation event without debouncing/rate-limit burns CPU and could be abused via DOM-style events.

Affected area

src/utils/security/phishingProtection.ts

Steps to reproduce / impact

Excessive clones / iframes force N domain checks per second.

Expected behaviour

Memoise per window.location.origin for the lifetime of the page, and rate-limit background reporting.

Acceptance criteria

  • Memoisation in place.
  • Add a benchmark test confirming constant-time verification regardless of count.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programperformancePerformance / bundle / runtimepriority/p2P2 — medium prioritysecuritySecurity issue or hardening opportunity

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions