Skip to content

security: open redirect / unsafe share URL risk in share buttons #451

Description

@nanaf6203-bit

Summary

The Property share button uses navigator.share + an unvalidated URL builder; the MortgageCalculator share HTML also serialises raw values into a URL.

Affected area

  • src/components/property/ShareButton.tsx
  • src/components/MortgageCalculator.tsx

Steps to reproduce / impact

A property title with newlines or shell metacharacters can break the share dialog or be misinterpreted downstream.

Expected behaviour

URL-encode all parameters, sanitise display strings to a constrained character set, validate the returned URL via URL constructor, and warn on cross-origin links.

Acceptance criteria

  • Helper centralising share-URL construction.
  • Tests with adversarial inputs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programpriority/p2P2 — medium prioritysecuritySecurity issue or hardening opportunity

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions