Skip to content

perf: WalletModal detection re-runs on every render #459

Description

@nanaf6203-bit

Summary

detectInstalledWallets in WalletModal runs on every render even though window.ethereum can't change between renders.

Affected area

src/components/WalletModal.tsx

Steps to reproduce

Open WalletModal; detection runs once. Hover on a wallet; detection still runs per state change.

Expected behaviour

Memoize via useMemo.

Acceptance criteria

  • Profiler shows zero recomputations on hover.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programperformancePerformance / bundle / runtimepriority/p3P3 — nice to have

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions