Replace 45 as-any casts in src/components: props and event payloads bypass type checks

[nanaf6203-bit]

Replace 45 as-any casts in src/components: props and event payloads bypass type checks

Labels / Complexity: bug · Medium Complexity — Medium

Problem

src/components/ contains 45 as any casts (verified by grep), the second-highest directory after src/utils (116). The casts appear in props, event handlers, and data passed between components — the exact interfaces that change when a prop or payload is renamed.

• Component contract drift compiles silently. A renamed prop or reshaped event payload type-checks through as any and breaks at runtime, often as a confusing render failure.
• The casts cluster in the dashboard and property components where data flows from services into charts and forms — the surfaces most likely to change shape as the mock data (issue14 #20, Mobile-First Property Viewing Experience #21) is replaced with real data.

Why this is architecturally hard

1. The real types exist or must be declared. Most casts sit next to types that are already declared (@/types/property, chart data shapes); the fix is threading the declared types through, which surfaces the places where components genuinely disagree with their data sources.
2. Some casts are chart-library workarounds. Charting libs (recharts-style) often have loose payload types; those need a typed adapter, not a bare cast — a small design decision per chart family.
3. The mock-data migrations depend on this. When issue14 #20/Mobile-First Property Viewing Experience #21 replace mock constants with real data, the cast sites are where the shape mismatch will surface; fixing the casts first makes those migrations safe.

Acceptance criteria

• All as any casts in src/components/ are replaced with real types or typed adapters.
• npx tsc --noEmit passes; npm test passes with no behavior change.
• The PR reports the repository-wide as any count before and after.

Out of scope

as any in src/utils (tracked separately); the mock-data migrations (#20, #21).

Getting started

• grep -rn "as any" src/components --include=*.tsx — the sites
• src/types/ — the shared type declarations

Commands: npx tsc --noEmit, npm test.

Good first files to read: src/components/dashboard/, src/types/.

[Ayinkx01]

@Ayinkx01 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi i would like to work on this issue please assign to me
I can do it perfectly

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ayinkx01 to this issue.

[lovesmilesmall-hue]

@lovesmilesmall-hue has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I am applying for issue 866 to implement the described solution, reviewing the relevant source files first and delivering changes that satisfy the acceptance criteria while ensuring all tests pass.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @lovesmilesmall-hue to this issue.

[drips-wave]

Congratulations, @lovesmilesmall-hue! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @lovesmilesmall-hue: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @lovesmilesmall-hue as part of the Stellar Wave Program's 8th Wave 🥳

😎 @lovesmilesmall-hue: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.