portfolioStore has no tests: portfolio aggregation state is uncovered

[nanaf6203-bit]

portfolioStore has no tests: portfolio aggregation state is uncovered

Labels / Complexity: testing · Medium Complexity — Medium

Problem

portfolioStore (src/store/portfolioStore.ts) holds the aggregated portfolio the dashboard renders. It has no tests — and it is the store that will consume the mock-backed PortfolioService (#20), so its behavior must be pinned before the data source changes.

Why this is architecturally hard

1. Aggregation is the test design. The store merges holdings/values into the dashboard's derived state; tests must pin how partial data is combined.
2. It is the mock-migration seam. With issue14 #20 replacing mock holdings, tests written now freeze the store's contract so the migration cannot silently change what the dashboard shows.

Acceptance criteria

• Tests cover portfolio load, aggregation, and empty/error states.
• Tests run in CI via npm test.

Out of scope

The portfolio mock migration (#20); other stores.

Getting started

• src/store/portfolioStore.ts — the store
• src/store/__tests__/transactionStore.test.ts — the pattern

Commands: npm test.

Good first files to read: src/store/portfolioStore.ts.

[Theodoradev]

@Theodoradev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, i would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Theodoradev to this issue.

[RUKAYAT-CODER]

@RUKAYAT-CODER has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer, can i work on this task?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @RUKAYAT-CODER to this issue.

[zakariyaufarida5-wq]

@zakariyaufarida5-wq has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi can i work on this task?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @zakariyaufarida5-wq to this issue.

[drips-wave]

Congratulations, @zakariyaufarida5-wq! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @zakariyaufarida5-wq: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @zakariyaufarida5-wq as part of the Stellar Wave Program's 8th Wave 🥳

😎 @zakariyaufarida5-wq: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.