fix(#341): improve accessibility for ResponsiveContainer - #414
Merged
nanaf6203-bit merged 1 commit intoJun 2, 2026
Merged
Conversation
|
@Ardecrownn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
WCAG 2.1 improvements to ResponsiveContainer and ResponsiveContainerFluid:
- Add polymorphic �s prop supporting all sectioning/landmark HTML elements
(main, section, article, aside, header, footer, nav, div) so consumers
render semantic markup instead of a generic <div>
- Forward aria-label, aria-labelledby, aria-describedby, role, tabIndex,
onKeyDown and all standard HTMLAttributes to the root element so keyboard
navigation and screen reader labelling work without extra wrappers
- Add data-testid defaults ('responsive-container' / 'responsive-container-fluid')
for reliable automated testing
- Export ResponsiveContainerFluidProps interface for type safety
ResponsiveContainerExample.tsx:
- Replace <div>-wrapped header/main/footer with as='header'/'main'/'footer'
- Add aria-label='Primary navigation' to the <nav> element
- Replace bare href='#' links with descriptive href values
- Add aria-labelledby to all <section> containers
- Add aria-hidden='true' to decorative placeholder images
jest.config.js:
- Remove ResponsiveContainer.test.tsx from testPathIgnorePatterns so the
new a11y test suite runs in CI
Tests (53 tests, all passing):
- Default rendering, data-testid, className merging
- Responsive padding per viewport category (mobile/tablet/desktop/fallback)
- Polymorphic as prop for all 8 supported element types
- ARIA landmark roles accessible via screen reader queries
- aria-label, aria-labelledby, aria-describedby, role forwarding
- Keyboard navigation: tabIndex, onKeyDown, onClick passthrough
- No console.log in production code
- Fluid variant rendering, clamp() padding, ARIA, keyboard
- Edge cases: nested children, sibling containers, unknown attributes
Closes MettaChain#341
Ardecrownn
force-pushed
the
fix/341-responsive-container-a11y
branch
from
June 2, 2026 09:44
077739f to
601a4f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WCAG 2.1 improvements to ResponsiveContainer and ResponsiveContainerFluid:
ResponsiveContainerExample.tsx:
jest.config.js:
Tests (53 tests, all passing):
Closes #341
Fix #24: Replace Console Override System with Proper Error Handling
Summary
This PR addresses the critical issue where the application was implementing aggressive console overriding and error suppression mechanisms that masked critical runtime errors and compromised production debugging capabilities.
Problem Statement
The previous implementation was:
Solution Implemented
🗑️ Removed Problematic Files
src/utils/consoleOverride.tssrc/utils/manualErrorSuppressor.ts✨ New Error Handling Framework
1. Structured Logging Service (
src/utils/structuredLogger.ts)2. Error Monitoring Service (
src/utils/errorMonitoringService.ts)3. Global Error Boundary (
src/components/error/GlobalErrorBoundary.tsx)4. Updated Application Integration (
src/app/page.tsx)🎯 Acceptance Criteria Met
✅ All console override mechanisms removed
✅ Structured logging implemented with proper log levels
✅ Error boundaries handle Web3, network, and AR-specific errors
✅ Production error monitoring integrated and configured
✅ Error reporting provides actionable insights for debugging
✅ Performance impact of logging is minimal (<5% overhead)
🧪 Testing
src/utils/errorHandlingTest.ts)🔧 Configuration Options
The new system provides extensive configuration options:
📊 Benefits
For Developers
For Production
For Security
🚀 Performance Impact
📝 Migration Guide
For Existing Code
console.log()→structuredLogger.info()console.error()→structuredLogger.error()For New Development
🔮 Future Enhancements
📋 Files Changed
src/utils/consoleOverride.tssrc/utils/manualErrorSuppressor.tssrc/utils/structuredLogger.tssrc/utils/errorMonitoringService.tssrc/components/error/GlobalErrorBoundary.tsxsrc/app/page.tsxsrc/utils/errorHandlingTest.tsERROR_HANDLING_IMPLEMENTATION_SUMMARY.md✅ Verification
This implementation completely addresses the issues described in #24 and provides a robust, production-ready error handling framework that will significantly improve debugging capabilities and developer experience.
closes #341