security: replace env-or-default patterns with fail-closed requireEnv helper (#444) - #543
Merged
nanaf6203-bit merged 1 commit intoJun 28, 2026
Conversation
… helper (MettaChain#441, MettaChain#444) - Remove hardcoded fallback REVALIDATE_WEBHOOK_SECRET from revalidate route - Create centralized requireEnv/requireEnvStrict helpers in src/lib/requireEnv.ts - Add test suite for requireEnv helpers - requireEnvStrict throws in all environments when env var is missing - requireEnv provides optional default with dev-only warning
|
@davidsoniaudin2-oss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Fail-closed is the right call. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces env-or-default patterns in API routes with a centralized fail-closed
equireEnv\ helper.
Changes
equireEnv\ and
equireEnvStrict\ functions
equireEnvStrict\ instead
Related Issues
Closes #441 - hardcoded fallback REVALIDATE_WEBHOOK_SECRET
Closes #444 - replace env-or-default patterns with fail-closed helpers
closes #443
closes #447