fix(security): store salted hash of deviceId instead of plaintext UUID - #546
Merged
nanaf6203-bit merged 2 commits intoJun 29, 2026
Conversation
- Replace localStorage plaintext UUID storage with salted hash - Add per-session salt stored in sessionStorage - Add synchronous hash function for device identity - Update tests to verify hashed storage behavior Closes MettaChain#448
|
@danieloche635-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Subsumed by #560 — same files, same lines resolved there. Closing this duplicate. |
nanaf6203-bit
requested changes
Jun 29, 2026
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Thanks @danieloche635-bit — great catch on #448. The salted-hash storage for deviceId is exactly the right move. This branch has merge conflicts against current main though — please rebase and resolve so we can land it. 🔐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\getSecurityDeviceId()\ was storing the raw device UUID in localStorage, making the device fingerprint reusable for impersonation across sessions.
Changes
Tests
Closes #448
closes #431
closes #442
closes #439