perf: defer service worker registration with requestIdleCallback (#461) - #558
Merged
nanaf6203-bit merged 1 commit intoJun 28, 2026
Merged
Conversation
|
@gbengaeben Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Smart perf fix. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defers service worker registration using
requestIdleCallbackto avoid blocking the initial paint and improve Time to Interactive (TTI).Problem
ServiceWorkerRegistrationwas eagerly registering the service worker on every page load (vialoadevent ordocument.readyState === 'complete'), including on routes that don't require offline support. This blocks the main thread and increases TTI.Solution
scheduleWhenIdle()helper that usesrequestIdleCallbackwith a 5-second timeoutsetTimeout(2000)whenrequestIdleCallbackis unavailablestartQueueAutoFlush()is still called eagerly (it's lightweight)Changes
ServiceWorkerRegistration.tsx: AddedscheduleWhenIdlehelper, removed eager register-on-load logicServiceWorkerRegistration.test.tsx: Rewritten from vitest to jest, added tests for deferred registration, idle callback, fallback to setTimeout, cancellation on unmount, and error handling (10 tests passing)Closes #461