Skip to content

albumart: Switch to {"binary": b"..."} results#141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mic92 merged 6 commits into from
Nov 27, 2020
Merged

albumart: Switch to {"binary": b"..."} results #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7eba388
tests: Remove old Python 2 workarounds
chrysn Nov 23, 2020
27cdec3
asyncio: Raise exceptions from iterable commands
chrysn Nov 21, 2020
bafaf4b
asyncio: Rewrite core loop to be friendly to non-linebase extension
chrysn Nov 23, 2020
3474a8d
asyncio: Add support for binary data (albumart)
chrysn Nov 23, 2020
019e49d
albumart / binary: Switch to returning full dictionary
chrysn Nov 24, 2020
314769a
tests: Adjust to binary now reading through existing interfaces
chrysn Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/topics/commands.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -605,8 +605,9 @@ The music database

*URI* is always a single file or URL.

The returned value is the binary contents of the album art image. If the given URI is invalid,
or the song does not have an album cover art file that MPD recognizes, a CommandError is thrown.
The returned value is a dictionary containing the album art image in its
``'binary'`` entry. If the given URI is invalid, or the song does not have
an album cover art file that MPD recognizes, a CommandError is thrown.

@Mic92Mic92Nov 27, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So albumart will throw an error if a song has no picture or only if it is invalid?

@chrysnchrysnNov 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPD will report an error if no album art is found (and it does not do any validation on it). This is inconsistent with its handling of readpicture, which returns empty OK if there's no picture.

Given that most of python-mpd2 is diving comparatively raw access to most MPD functionality, it may make sense to accept this inconsistency here, but about it in the documentation and possibly ask for clarification in the protocol development.

@Mic92Mic92Nov 27, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

.. function:: MPDClient.count(tag, needle[, ..., "group", grouptype])


Expand Down
Loading