Uh oh!
There was an error while loading. Please reload this page.
Fix CMake targets include path propagation - #414
Open
FredeHoey wants to merge 2 commits into
Open
Conversation
In all places where the cmake files call include_directories, the first and second parameters are a target and a scope specifier. For include_directories, that means literally adding those parameters to the include path via -I flags, ie. ```cmake include_directories(target PUBLIC ...) -> -Itarget -IPUBLIC ``` This was probably intended to be a target_include_directories instead, such that any library or executable calling target_link_libraries would also have those includes propagated see: https://cmake.org/cmake/help/latest/command/include_directories.htmlhttps://cmake.org/cmake/help/latest/command/target_include_directories.html#command:target_include_directories
This PR has been marked as stale and will be automatically closed in 7 days. |
This PR has been marked as stale and will be automatically closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all places where the cmake files call include_directories, the first and second parameters are a target and a scope specifier. For include_directories, that means literally adding those parameters to the include path via -I flags, ie.
This was probably intended to be a target_include_directories instead, such that any library or executable calling target_link_libraries would also have those includes propagated
see:
https://cmake.org/cmake/help/latest/command/include_directories.htmlhttps://cmake.org/cmake/help/latest/command/target_include_directories.html#command:target_include_directories
Checklist