Skip to content

Fix #30557 Narrow non-declared unions by discriminant - #30593

Closed
Jack Williams (jack-williams) wants to merge 30 commits into
microsoft:masterfrom
jack-williams:narrow-non-declared-union
Closed

Fix #30557 Narrow non-declared unions by discriminant#30593
Jack Williams (jack-williams) wants to merge 30 commits into
microsoft:masterfrom
jack-williams:narrow-non-declared-union

Conversation

@jack-williams

@jack-williamsJack Williams (jack-williams) commented Mar 26, 2019

Copy link
Copy Markdown
Collaborator

Fixes#30557

@jack-williamsJack Williams (jack-williams) mentioned this pull request Mar 26, 2019
Closed
@Validark

Niles Salter (Validark) commented Mar 26, 2019

Copy link
Copy Markdown

Short and seemingly straightforward. Hopefully someone with the power to merge this can review it soon. Thank you for tracking this bug down and fixing it!

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Mar 26, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 26, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at e130cd6. You can monitor the build here. It should now contribute to this PR's status checks.

@jack-williams

Jack Williams (jack-williams) commented Mar 26, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Perf regression?

@jack-williams

Jack Williams (jack-williams) commented Mar 26, 2019

Copy link
Copy Markdown
CollaboratorAuthor

For large unions without a discriminant I was computing the union of the property twice, which I guess is expensive. Not sure if this is enough to fix the problem however.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Mar 26, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this new commit

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 26, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at e038290. You can monitor the build here. It should now contribute to this PR's status checks.

@jack-williams

Jack Williams (jack-williams) commented Mar 26, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Edit: Ah, I think the property cache is getting wrecked because we are no longer always hitting the declared type. I’ll try fix this by first testing the declared type then falling back if it’s not a union.

I dont know if anyone with more knowledge than me sees something obvious that I’m missing. One alternative might be to limit the narrowing to cases where the declared type is unknown or object, though that doesn’t feel especially principled.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Mar 27, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this because maybe it works now!

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 61d2eaf. You can monitor the build here. It should now contribute to this PR's status checks.

@jack-williams

Jack Williams (jack-williams) commented Mar 27, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Sorry TypeScript Bot (@typescript-bot), I hope I don't let you down

Narrator: He did

@Validark

Niles Salter (Validark) commented Mar 27, 2019

Copy link
Copy Markdown

Psyched!

@jack-williams

Jack Williams (jack-williams) commented Mar 27, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Ryan Cavanaugh (@RyanCavanaugh)

The RWC tests were running at 40m and going, so I don't think my change fixed that. I've changed it to only ever narrow from one type. Before, if the declared type was not a union but narrowed to a big union, then each subsequent narrowing would hit a different property cache.

@jack-williamsJack Williams (jack-williams) mentioned this pull request Apr 5, 2019
Closed
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Apr 25, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 4b3a96a. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Apr 25, 2019

Copy link
Copy Markdown
Member

Forgot to sync this branch with master; need to rerun

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Apr 25, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 8ed48e6. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Apr 26, 2019

Copy link
Copy Markdown
Member

RWC is actually clean

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 26, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the perf test suite on this PR at 8ed48e6. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@jack-williams

Jack Williams (jack-williams) commented Nov 3, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this now I've added cases for assignment

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 3, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 776ddb4. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 3, 2019

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..30593

Metricmaster30593DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used355,152k (± 0.01%)356,901k (± 0.01%)+1,749k (+ 0.49%)356,837k357,022k
Parse Time1.62s (± 0.65%)1.62s (± 0.42%)+0.00s (+ 0.06%)1.61s1.64s
Bind Time0.87s (± 1.16%)0.87s (± 0.92%)+0.00s (+ 0.23%)0.85s0.89s
Check Time4.53s (± 0.59%)4.52s (± 0.32%)-0.01s (- 0.18%)4.50s4.56s
Emit Time5.28s (± 0.72%)5.24s (± 0.69%)-0.04s (- 0.81%)5.15s5.32s
Total Time12.30s (± 0.51%)12.25s (± 0.38%)-0.05s (- 0.40%)12.13s12.35s
Monaco - node (v10.16.3, x64)
Memory used366,012k (± 0.02%)365,984k (± 0.01%)-28k (- 0.01%)365,920k366,109k
Parse Time1.27s (± 0.76%)1.25s (± 0.52%)-0.02s (- 1.49%)1.24s1.27s
Bind Time0.76s (± 0.39%)0.75s (± 0.48%)-0.00s (- 0.53%)0.75s0.76s
Check Time4.65s (± 0.69%)4.66s (± 0.36%)+0.01s (+ 0.24%)4.63s4.70s
Emit Time2.96s (± 0.74%)2.94s (± 0.93%)-0.02s (- 0.71%)2.90s3.01s
Total Time9.64s (± 0.42%)9.61s (± 0.40%)-0.03s (- 0.34%)9.53s9.71s
TFS - node (v10.16.3, x64)
Memory used321,701k (± 0.02%)321,641k (± 0.01%)-60k (- 0.02%)321,574k321,688k
Parse Time0.96s (± 0.71%)0.95s (± 0.47%)-0.01s (- 1.24%)0.94s0.96s
Bind Time0.72s (± 1.31%)0.72s (± 1.30%)-0.00s (- 0.14%)0.70s0.74s
Check Time4.12s (± 0.40%)4.12s (± 0.55%)-0.00s (- 0.12%)4.06s4.16s
Emit Time3.06s (± 0.63%)3.06s (± 0.88%)-0.01s (- 0.23%)3.00s3.12s
Total Time8.88s (± 0.33%)8.85s (± 0.56%)-0.03s (- 0.29%)8.72s8.95s
Angular - node (v12.1.0, x64)
Memory used330,667k (± 0.04%)332,350k (± 0.02%)+1,684k (+ 0.51%)332,182k332,481k
Parse Time1.56s (± 0.48%)1.57s (± 0.85%)+0.01s (+ 0.38%)1.55s1.60s
Bind Time0.85s (± 0.79%)0.86s (± 1.31%)+0.01s (+ 1.65%)0.84s0.89s
Check Time4.47s (± 0.66%)4.46s (± 0.55%)-0.01s (- 0.25%)4.42s4.53s
Emit Time5.48s (± 0.97%)5.45s (± 0.54%)-0.03s (- 0.60%)5.39s5.51s
Total Time12.36s (± 0.62%)12.33s (± 0.36%)-0.02s (- 0.19%)12.23s12.42s
Monaco - node (v12.1.0, x64)
Memory used345,751k (± 0.01%)345,728k (± 0.02%)-23k (- 0.01%)345,541k345,866k
Parse Time1.23s (± 0.75%)1.22s (± 0.83%)-0.02s (- 1.30%)1.20s1.25s
Bind Time0.72s (± 0.51%)0.73s (± 1.04%)+0.00s (+ 0.14%)0.71s0.75s
Check Time4.50s (± 0.37%)4.49s (± 0.43%)-0.01s (- 0.27%)4.46s4.53s
Emit Time3.01s (± 0.57%)2.99s (± 0.46%)-0.02s (- 0.80%)2.95s3.01s
Total Time9.47s (± 0.29%)9.42s (± 0.38%)-0.05s (- 0.55%)9.33s9.49s
TFS - node (v12.1.0, x64)
Memory used304,008k (± 0.02%)304,000k (± 0.02%)-9k (- 0.00%)303,880k304,114k
Parse Time0.95s (± 0.61%)0.95s (± 0.47%)-0.00s (- 0.21%)0.94s0.96s
Bind Time0.69s (± 0.94%)0.69s (± 0.72%)-0.00s (- 0.29%)0.68s0.70s
Check Time4.05s (± 0.62%)4.06s (± 0.44%)+0.01s (+ 0.22%)4.04s4.12s
Emit Time3.10s (± 1.05%)3.12s (± 1.08%)+0.02s (+ 0.58%)3.06s3.19s
Total Time8.79s (± 0.53%)8.81s (± 0.36%)+0.02s (+ 0.24%)8.74s8.87s
Angular - node (v8.9.0, x64)
Memory used349,951k (± 0.02%)351,617k (± 0.01%)+1,666k (+ 0.48%)351,500k351,703k
Parse Time2.11s (± 0.48%)2.11s (± 0.42%)+0.00s (+ 0.24%)2.10s2.14s
Bind Time0.91s (± 0.80%)0.92s (± 0.52%)+0.01s (+ 0.99%)0.91s0.93s
Check Time5.28s (± 0.36%)5.33s (± 0.62%)+0.04s (+ 0.83%)5.26s5.40s
Emit Time6.26s (± 0.66%)6.25s (± 0.61%)-0.01s (- 0.13%)6.15s6.32s
Total Time14.55s (± 0.30%)14.61s (± 0.41%)+0.06s (+ 0.38%)14.44s14.72s
Monaco - node (v8.9.0, x64)
Memory used363,805k (± 0.01%)363,792k (± 0.01%)-13k (- 0.00%)363,694k363,844k
Parse Time1.57s (± 0.61%)1.56s (± 0.40%)-0.01s (- 0.45%)1.55s1.58s
Bind Time0.93s (± 0.83%)0.91s (± 0.74%)-0.01s (- 1.61%)0.90s0.93s
Check Time5.56s (± 0.35%)5.55s (± 0.49%)-0.01s (- 0.18%)5.50s5.61s
Emit Time3.05s (± 0.69%)3.03s (± 0.99%)-0.01s (- 0.46%)3.00s3.14s
Total Time11.11s (± 0.39%)11.06s (± 0.37%)-0.05s (- 0.42%)11.00s11.17s
TFS - node (v8.9.0, x64)
Memory used320,571k (± 0.01%)320,550k (± 0.01%)-21k (- 0.01%)320,486k320,688k
Parse Time1.28s (± 0.29%)1.27s (± 0.53%)-0.00s (- 0.24%)1.25s1.28s
Bind Time0.74s (± 0.54%)0.74s (± 0.93%)-0.01s (- 0.81%)0.72s0.75s
Check Time4.76s (± 0.44%)4.75s (± 0.58%)-0.01s (- 0.15%)4.68s4.82s
Emit Time3.27s (± 1.00%)3.22s (± 0.87%)-0.05s (- 1.68%)3.17s3.29s
Total Time10.05s (± 0.47%)9.98s (± 0.57%)-0.07s (- 0.73%)9.89s10.14s
Angular - node (v8.9.0, x86)
Memory used198,699k (± 0.03%)199,564k (± 0.03%)+865k (+ 0.44%)199,434k199,712k
Parse Time2.04s (± 1.00%)2.04s (± 0.59%)-0.00s (- 0.25%)2.01s2.06s
Bind Time1.03s (± 1.58%)1.02s (± 0.69%)-0.01s (- 1.35%)1.01s1.04s
Check Time4.82s (± 0.63%)4.82s (± 0.72%)+0.00s (+ 0.06%)4.74s4.93s
Emit Time6.07s (± 1.16%)6.18s (± 1.70%)+0.12s (+ 1.93%)6.01s6.41s
Total Time13.96s (± 0.62%)14.06s (± 0.68%)+0.10s (+ 0.72%)13.85s14.27s
Monaco - node (v8.9.0, x86)
Memory used203,783k (± 0.02%)203,806k (± 0.02%)+23k (+ 0.01%)203,752k203,893k
Parse Time1.62s (± 0.40%)1.61s (± 0.75%)-0.01s (- 0.74%)1.59s1.64s
Bind Time0.75s (± 1.08%)0.75s (± 1.79%)+0.00s (+ 0.13%)0.73s0.79s
Check Time5.36s (± 0.77%)5.38s (± 0.33%)+0.02s (+ 0.37%)5.35s5.42s
Emit Time2.93s (± 1.25%)2.85s (± 0.87%)-0.08s (- 2.66%)2.81s2.92s
Total Time10.67s (± 0.39%)10.60s (± 0.44%)-0.07s (- 0.66%)10.51s10.70s
TFS - node (v8.9.0, x86)
Memory used180,549k (± 0.02%)180,557k (± 0.02%)+8k (+ 0.00%)180,470k180,624k
Parse Time1.31s (± 0.83%)1.30s (± 0.57%)-0.01s (- 0.61%)1.29s1.32s
Bind Time0.70s (± 0.71%)0.69s (± 0.49%)-0.00s (- 0.43%)0.69s0.70s
Check Time4.51s (± 0.68%)4.50s (± 0.77%)-0.00s (- 0.11%)4.43s4.57s
Emit Time2.97s (± 1.03%)2.98s (± 0.81%)+0.01s (+ 0.27%)2.94s3.05s
Total Time9.48s (± 0.52%)9.48s (± 0.39%)0.00s ( 0.00%)9.40s9.57s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
BenchmarkNameIterations
Current3059310
Baselinemaster10

Closed
@jack-williams

Jack Williams (jack-williams) commented Nov 18, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at b31b417. You can monitor the build here. It should now contribute to this PR's status checks.

@jack-williams

Jack Williams (jack-williams) commented Nov 18, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at b31b417. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..30593

Metricmaster30593DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used354,643k (± 0.02%)356,838k (± 0.02%)+2,195k (+ 0.62%)356,722k356,957k
Parse Time1.62s (± 0.66%)1.64s (± 0.58%)+0.02s (+ 1.05%)1.62s1.66s
Bind Time0.86s (± 0.61%)0.87s (± 1.15%)+0.01s (+ 0.93%)0.85s0.90s
Check Time4.53s (± 0.57%)4.54s (± 0.54%)+0.02s (+ 0.42%)4.49s4.61s
Emit Time5.26s (± 0.73%)5.22s (± 0.53%)-0.04s (- 0.70%)5.16s5.28s
Total Time12.26s (± 0.41%)12.27s (± 0.39%)+0.01s (+ 0.09%)12.18s12.37s
Monaco - node (v10.16.3, x64)
Memory used365,977k (± 0.02%)365,964k (± 0.01%)-14k (- 0.00%)365,837k366,048k
Parse Time1.26s (± 0.80%)1.26s (± 0.77%)-0.01s (- 0.47%)1.25s1.29s
Bind Time0.75s (± 0.63%)0.75s (± 0.65%)+0.00s (+ 0.13%)0.74s0.76s
Check Time4.64s (± 0.34%)4.69s (± 0.71%)+0.05s (+ 0.99%)4.63s4.76s
Emit Time2.97s (± 0.81%)2.92s (± 0.90%)-0.04s (- 1.48%)2.87s2.98s
Total Time9.62s (± 0.41%)9.62s (± 0.59%)-0.00s (- 0.01%)9.53s9.75s
TFS - node (v10.16.3, x64)
Memory used321,608k (± 0.02%)321,649k (± 0.02%)+41k (+ 0.01%)321,519k321,780k
Parse Time0.97s (± 0.62%)0.96s (± 1.00%)-0.01s (- 1.14%)0.93s0.97s
Bind Time0.73s (± 1.14%)0.72s (± 1.14%)-0.01s (- 1.24%)0.70s0.74s
Check Time4.13s (± 0.39%)4.13s (± 0.59%)+0.00s (+ 0.02%)4.08s4.18s
Emit Time3.06s (± 0.72%)3.06s (± 1.32%)+0.01s (+ 0.16%)2.98s3.21s
Total Time8.88s (± 0.38%)8.87s (± 0.72%)-0.01s (- 0.15%)8.76s9.07s
Angular - node (v12.1.0, x64)
Memory used330,178k (± 0.06%)332,264k (± 0.08%)+2,086k (+ 0.63%)331,235k332,504k
Parse Time1.58s (± 0.73%)1.58s (± 0.42%)+0.01s (+ 0.38%)1.57s1.60s
Bind Time0.84s (± 0.58%)0.85s (± 0.70%)+0.01s (+ 1.18%)0.84s0.87s
Check Time4.46s (± 0.30%)4.48s (± 0.58%)+0.02s (+ 0.45%)4.43s4.53s
Emit Time5.50s (± 1.04%)5.52s (± 0.97%)+0.01s (+ 0.22%)5.45s5.66s
Total Time12.38s (± 0.52%)12.44s (± 0.51%)+0.05s (+ 0.44%)12.34s12.61s
Monaco - node (v12.1.0, x64)
Memory used345,665k (± 0.01%)345,738k (± 0.02%)+73k (+ 0.02%)345,578k345,888k
Parse Time1.23s (± 0.67%)1.23s (± 0.77%)-0.01s (- 0.65%)1.20s1.25s
Bind Time0.73s (± 0.91%)0.74s (± 1.29%)+0.00s (+ 0.41%)0.72s0.76s
Check Time4.50s (± 0.35%)4.52s (± 0.38%)+0.02s (+ 0.51%)4.49s4.57s
Emit Time3.04s (± 1.03%)3.01s (± 0.40%)-0.02s (- 0.76%)2.99s3.05s
Total Time9.50s (± 0.29%)9.50s (± 0.26%)-0.00s (- 0.04%)9.45s9.54s
TFS - node (v12.1.0, x64)
Memory used304,116k (± 0.02%)304,004k (± 0.02%)-111k (- 0.04%)303,891k304,139k
Parse Time0.96s (± 1.09%)0.95s (± 0.79%)-0.01s (- 1.35%)0.93s0.97s
Bind Time0.68s (± 0.50%)0.69s (± 1.36%)+0.01s (+ 1.46%)0.68s0.72s
Check Time4.06s (± 0.53%)4.05s (± 0.54%)-0.01s (- 0.32%)4.01s4.12s
Emit Time3.11s (± 0.69%)3.10s (± 0.41%)-0.01s (- 0.32%)3.08s3.12s
Total Time8.81s (± 0.43%)8.80s (± 0.30%)-0.02s (- 0.18%)8.73s8.86s
Angular - node (v8.9.0, x64)
Memory used349,535k (± 0.02%)351,626k (± 0.02%)+2,092k (+ 0.60%)351,468k351,730k
Parse Time2.11s (± 0.63%)2.12s (± 0.63%)+0.01s (+ 0.43%)2.10s2.16s
Bind Time0.91s (± 0.68%)0.93s (± 0.64%)+0.02s (+ 1.87%)0.92s0.94s
Check Time5.30s (± 0.39%)5.33s (± 0.78%)+0.03s (+ 0.62%)5.22s5.41s
Emit Time6.25s (± 1.87%)6.33s (± 0.78%)+0.08s (+ 1.28%)6.21s6.43s
Total Time14.57s (± 0.83%)14.71s (± 0.57%)+0.14s (+ 0.93%)14.48s14.86s
Monaco - node (v8.9.0, x64)
Memory used363,735k (± 0.01%)363,795k (± 0.01%)+60k (+ 0.02%)363,688k363,971k
Parse Time1.57s (± 0.84%)1.56s (± 0.41%)-0.01s (- 0.64%)1.55s1.58s
Bind Time0.93s (± 0.48%)0.92s (± 0.67%)-0.01s (- 1.18%)0.91s0.94s
Check Time5.58s (± 0.54%)5.57s (± 0.57%)-0.01s (- 0.20%)5.50s5.63s
Emit Time3.07s (± 0.92%)3.05s (± 0.72%)-0.01s (- 0.39%)3.00s3.10s
Total Time11.15s (± 0.46%)11.10s (± 0.37%)-0.04s (- 0.40%)11.02s11.19s
TFS - node (v8.9.0, x64)
Memory used320,545k (± 0.01%)320,549k (± 0.02%)+4k (+ 0.00%)320,453k320,695k
Parse Time1.27s (± 0.60%)1.27s (± 0.53%)-0.00s (- 0.16%)1.26s1.29s
Bind Time0.74s (± 0.64%)0.74s (± 0.64%)0.00s ( 0.00%)0.73s0.75s
Check Time4.75s (± 0.25%)4.74s (± 0.49%)-0.01s (- 0.29%)4.70s4.81s
Emit Time3.23s (± 0.71%)3.21s (± 0.80%)-0.02s (- 0.65%)3.13s3.26s
Total Time10.00s (± 0.33%)9.96s (± 0.41%)-0.04s (- 0.38%)9.84s10.06s
Angular - node (v8.9.0, x86)
Memory used198,437k (± 0.03%)199,545k (± 0.03%)+1,109k (+ 0.56%)199,431k199,652k
Parse Time2.02s (± 0.55%)2.04s (± 0.74%)+0.01s (+ 0.74%)2.01s2.07s
Bind Time1.03s (± 1.41%)1.01s (± 0.59%)-0.02s (- 1.55%)1.00s1.03s
Check Time4.79s (± 0.58%)4.82s (± 0.51%)+0.03s (+ 0.58%)4.76s4.89s
Emit Time6.09s (± 0.95%)6.12s (± 1.58%)+0.02s (+ 0.38%)6.00s6.38s
Total Time13.94s (± 0.45%)13.99s (± 0.70%)+0.05s (+ 0.36%)13.83s14.26s
Monaco - node (v8.9.0, x86)
Memory used203,759k (± 0.02%)203,759k (± 0.02%)0k ( 0.00%)203,681k203,839k
Parse Time1.61s (± 0.47%)1.61s (± 1.05%)-0.00s (- 0.12%)1.59s1.67s
Bind Time0.75s (± 1.04%)0.75s (± 0.82%)+0.00s (+ 0.27%)0.74s0.76s
Check Time5.43s (± 0.52%)5.37s (± 0.78%)-0.05s (- 0.98%)5.24s5.44s
Emit Time2.87s (± 0.71%)2.90s (± 2.11%)+0.03s (+ 1.05%)2.84s3.13s
Total Time10.66s (± 0.39%)10.63s (± 0.37%)-0.03s (- 0.25%)10.56s10.71s
TFS - node (v8.9.0, x86)
Memory used180,599k (± 0.02%)180,558k (± 0.02%)-40k (- 0.02%)180,490k180,659k
Parse Time1.31s (± 0.72%)1.31s (± 0.81%)-0.00s (- 0.31%)1.29s1.33s
Bind Time0.70s (± 0.83%)0.70s (± 0.74%)+0.00s (+ 0.29%)0.69s0.71s
Check Time4.49s (± 0.50%)4.49s (± 0.46%)+0.00s (+ 0.09%)4.45s4.55s
Emit Time2.98s (± 1.45%)2.98s (± 0.61%)-0.00s (- 0.13%)2.93s3.02s
Total Time9.47s (± 0.53%)9.47s (± 0.38%)-0.00s (- 0.03%)9.38s9.53s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory7 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
BenchmarkNameIterations
Current3059310
Baselinemaster10

@jack-williams

Jack Williams (jack-williams) commented Nov 19, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 356b91d. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..30593

Metricmaster30593DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used354,635k (± 0.02%)356,857k (± 0.02%)+2,222k (+ 0.63%)356,685k356,999k
Parse Time1.62s (± 0.53%)1.62s (± 0.49%)-0.00s (- 0.25%)1.60s1.63s
Bind Time0.86s (± 0.35%)0.87s (± 0.81%)+0.01s (+ 1.28%)0.85s0.88s
Check Time4.54s (± 0.72%)4.53s (± 0.45%)-0.01s (- 0.15%)4.49s4.59s
Emit Time5.25s (± 0.65%)5.25s (± 0.88%)-0.01s (- 0.15%)5.16s5.36s
Total Time12.27s (± 0.48%)12.26s (± 0.42%)-0.01s (- 0.07%)12.17s12.37s
Monaco - node (v10.16.3, x64)
Memory used365,938k (± 0.02%)366,033k (± 0.01%)+95k (+ 0.03%)365,920k366,101k
Parse Time1.27s (± 0.70%)1.25s (± 0.65%)-0.01s (- 1.10%)1.24s1.27s
Bind Time0.76s (± 0.65%)0.75s (± 0.59%)-0.00s (- 0.53%)0.74s0.76s
Check Time4.65s (± 0.71%)4.65s (± 0.46%)-0.00s (- 0.02%)4.61s4.70s
Emit Time2.94s (± 0.62%)2.95s (± 0.68%)+0.01s (+ 0.20%)2.91s2.98s
Total Time9.61s (± 0.54%)9.60s (± 0.44%)-0.01s (- 0.10%)9.51s9.68s
TFS - node (v10.16.3, x64)
Memory used321,649k (± 0.02%)321,625k (± 0.02%)-24k (- 0.01%)321,487k321,714k
Parse Time0.96s (± 0.63%)0.95s (± 0.42%)-0.00s (- 0.42%)0.94s0.96s
Bind Time0.72s (± 1.34%)0.71s (± 1.24%)-0.01s (- 0.83%)0.69s0.73s
Check Time4.12s (± 0.55%)4.13s (± 0.38%)+0.02s (+ 0.49%)4.10s4.17s
Emit Time3.05s (± 0.69%)3.05s (± 0.74%)+0.00s (+ 0.03%)3.01s3.11s
Total Time8.83s (± 0.49%)8.85s (± 0.46%)+0.02s (+ 0.18%)8.80s8.96s
Angular - node (v12.1.0, x64)
Memory used330,236k (± 0.02%)332,215k (± 0.08%)+1,979k (+ 0.60%)331,465k332,465k
Parse Time1.57s (± 0.75%)1.57s (± 0.43%)-0.00s (- 0.13%)1.55s1.58s
Bind Time0.84s (± 0.58%)0.85s (± 0.97%)+0.01s (+ 1.18%)0.84s0.88s
Check Time4.46s (± 0.30%)4.48s (± 0.88%)+0.02s (+ 0.45%)4.40s4.57s
Emit Time5.48s (± 0.98%)5.49s (± 1.15%)+0.02s (+ 0.29%)5.36s5.67s
Total Time12.35s (± 0.51%)12.40s (± 0.76%)+0.04s (+ 0.36%)12.18s12.62s
Monaco - node (v12.1.0, x64)
Memory used345,643k (± 0.02%)345,745k (± 0.02%)+102k (+ 0.03%)345,606k345,897k
Parse Time1.23s (± 0.56%)1.22s (± 0.55%)-0.00s (- 0.24%)1.21s1.23s
Bind Time0.73s (± 0.64%)0.73s (± 0.96%)-0.00s (- 0.14%)0.72s0.75s
Check Time4.51s (± 0.25%)4.51s (± 0.30%)+0.00s (+ 0.07%)4.47s4.54s
Emit Time3.04s (± 0.72%)3.01s (± 1.09%)-0.03s (- 0.89%)2.96s3.12s
Total Time9.50s (± 0.25%)9.47s (± 0.48%)-0.03s (- 0.33%)9.40s9.62s
TFS - node (v12.1.0, x64)
Memory used304,038k (± 0.01%)304,012k (± 0.02%)-26k (- 0.01%)303,902k304,122k
Parse Time0.96s (± 0.68%)0.94s (± 0.36%)-0.01s (- 1.57%)0.94s0.95s
Bind Time0.68s (± 0.87%)0.68s (± 1.21%)-0.00s (- 0.15%)0.67s0.71s
Check Time4.06s (± 0.51%)4.06s (± 0.43%)-0.01s (- 0.20%)4.00s4.08s
Emit Time3.12s (± 1.68%)3.10s (± 0.92%)-0.03s (- 0.90%)3.05s3.19s
Total Time8.83s (± 0.76%)8.78s (± 0.38%)-0.05s (- 0.58%)8.72s8.86s
Angular - node (v8.9.0, x64)
Memory used349,568k (± 0.01%)351,594k (± 0.02%)+2,026k (+ 0.58%)351,417k351,752k
Parse Time2.11s (± 0.74%)2.12s (± 0.49%)+0.01s (+ 0.52%)2.10s2.14s
Bind Time0.91s (± 0.80%)0.92s (± 0.67%)+0.01s (+ 0.99%)0.91s0.94s
Check Time5.29s (± 0.39%)5.28s (± 0.56%)-0.01s (- 0.23%)5.22s5.34s
Emit Time6.24s (± 1.34%)6.25s (± 1.04%)+0.01s (+ 0.21%)6.08s6.38s
Total Time14.55s (± 0.62%)14.57s (± 0.43%)+0.02s (+ 0.15%)14.40s14.69s
Monaco - node (v8.9.0, x64)
Memory used363,727k (± 0.02%)363,812k (± 0.02%)+85k (+ 0.02%)363,715k363,913k
Parse Time1.56s (± 0.41%)1.56s (± 0.22%)-0.01s (- 0.32%)1.55s1.56s
Bind Time0.93s (± 0.73%)0.92s (± 0.54%)-0.02s (- 2.03%)0.91s0.93s
Check Time5.54s (± 0.67%)5.54s (± 0.36%)-0.01s (- 0.13%)5.49s5.58s
Emit Time3.03s (± 0.61%)3.04s (± 0.43%)+0.01s (+ 0.23%)3.01s3.08s
Total Time11.07s (± 0.42%)11.05s (± 0.27%)-0.02s (- 0.22%)10.97s11.09s
TFS - node (v8.9.0, x64)
Memory used320,578k (± 0.02%)320,532k (± 0.01%)-46k (- 0.01%)320,407k320,618k
Parse Time1.27s (± 0.66%)1.27s (± 0.49%)+0.00s (+ 0.16%)1.26s1.28s
Bind Time0.74s (± 0.40%)0.74s (± 0.68%)-0.01s (- 0.94%)0.73s0.75s
Check Time4.72s (± 0.46%)4.74s (± 0.72%)+0.01s (+ 0.23%)4.65s4.82s
Emit Time3.22s (± 0.92%)3.23s (± 0.68%)+0.01s (+ 0.40%)3.19s3.29s
Total Time9.95s (± 0.45%)9.97s (± 0.48%)+0.02s (+ 0.20%)9.88s10.08s
Angular - node (v8.9.0, x86)
Memory used198,420k (± 0.02%)199,591k (± 0.02%)+1,171k (+ 0.59%)199,511k199,659k
Parse Time2.02s (± 0.51%)2.03s (± 0.59%)+0.01s (+ 0.59%)2.01s2.06s
Bind Time1.04s (± 1.44%)1.02s (± 0.60%)-0.02s (- 1.45%)1.01s1.03s
Check Time4.80s (± 0.45%)4.81s (± 0.62%)+0.00s (+ 0.10%)4.76s4.88s
Emit Time6.10s (± 1.16%)6.10s (± 1.48%)-0.01s (- 0.13%)6.00s6.35s
Total Time13.97s (± 0.61%)13.96s (± 0.73%)-0.00s (- 0.02%)13.79s14.24s
Monaco - node (v8.9.0, x86)
Memory used203,761k (± 0.02%)203,771k (± 0.02%)+11k (+ 0.01%)203,696k203,842k
Parse Time1.60s (± 0.46%)1.60s (± 0.46%)-0.00s (- 0.12%)1.58s1.61s
Bind Time0.75s (± 0.74%)0.75s (± 0.66%)-0.00s (- 0.27%)0.74s0.76s
Check Time5.41s (± 0.52%)5.39s (± 0.80%)-0.02s (- 0.41%)5.33s5.50s
Emit Time2.87s (± 1.13%)2.89s (± 1.74%)+0.02s (+ 0.70%)2.81s3.06s
Total Time10.63s (± 0.45%)10.62s (± 0.38%)-0.01s (- 0.07%)10.54s10.72s
TFS - node (v8.9.0, x86)
Memory used180,582k (± 0.02%)180,539k (± 0.02%)-43k (- 0.02%)180,466k180,652k
Parse Time1.30s (± 0.57%)1.30s (± 0.81%)+0.00s (+ 0.08%)1.29s1.33s
Bind Time0.70s (± 0.80%)0.69s (± 0.69%)-0.00s (- 0.72%)0.68s0.70s
Check Time4.50s (± 0.66%)4.48s (± 0.60%)-0.02s (- 0.44%)4.43s4.57s
Emit Time2.97s (± 1.02%)2.94s (± 0.90%)-0.03s (- 0.91%)2.89s3.00s
Total Time9.48s (± 0.56%)9.42s (± 0.33%)-0.05s (- 0.56%)9.37s9.52s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory7 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
BenchmarkNameIterations
Current3059310
Baselinemaster10

@jack-williams

Jack Williams (jack-williams) commented Nov 20, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 1925a6c. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 20, 2019

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..30593

Metricmaster30593DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used354,717k (± 0.02%)356,571k (± 0.02%)+1,854k (+ 0.52%)356,342k356,789k
Parse Time1.62s (± 0.45%)1.63s (± 0.85%)+0.01s (+ 0.55%)1.61s1.67s
Bind Time0.85s (± 0.58%)0.87s (± 1.23%)+0.02s (+ 1.87%)0.84s0.89s
Check Time4.52s (± 0.39%)4.56s (± 0.46%)+0.04s (+ 0.93%)4.53s4.60s
Emit Time5.24s (± 0.92%)5.26s (± 0.79%)+0.02s (+ 0.32%)5.17s5.38s
Total Time12.25s (± 0.53%)12.33s (± 0.57%)+0.08s (+ 0.65%)12.23s12.53s
Monaco - node (v10.16.3, x64)
Memory used365,966k (± 0.02%)366,115k (± 0.02%)+149k (+ 0.04%)365,922k366,214k
Parse Time1.26s (± 0.71%)1.26s (± 0.65%)-0.01s (- 0.40%)1.24s1.28s
Bind Time0.75s (± 0.65%)0.76s (± 0.39%)+0.00s (+ 0.53%)0.75s0.76s
Check Time4.65s (± 0.47%)4.69s (± 0.49%)+0.04s (+ 0.82%)4.65s4.74s
Emit Time2.95s (± 0.72%)2.96s (± 0.66%)+0.00s (+ 0.10%)2.93s3.01s
Total Time9.62s (± 0.42%)9.66s (± 0.40%)+0.04s (+ 0.41%)9.59s9.75s
TFS - node (v10.16.3, x64)
Memory used321,675k (± 0.02%)321,895k (± 0.02%)+220k (+ 0.07%)321,767k322,039k
Parse Time0.96s (± 0.54%)0.96s (± 0.97%)-0.00s (- 0.31%)0.94s0.98s
Bind Time0.72s (± 1.47%)0.72s (± 1.75%)-0.00s (- 0.55%)0.69s0.74s
Check Time4.12s (± 0.46%)4.14s (± 0.92%)+0.02s (+ 0.46%)4.09s4.24s
Emit Time3.05s (± 0.55%)3.05s (± 0.84%)-0.00s (- 0.07%)2.99s3.09s
Total Time8.86s (± 0.35%)8.87s (± 0.61%)+0.01s (+ 0.15%)8.75s8.99s
Angular - node (v12.1.0, x64)
Memory used330,300k (± 0.03%)331,906k (± 0.08%)+1,607k (+ 0.49%)330,920k332,262k
Parse Time1.58s (± 0.53%)1.59s (± 0.42%)+0.01s (+ 0.38%)1.57s1.60s
Bind Time0.85s (± 0.40%)0.86s (± 0.69%)+0.01s (+ 1.06%)0.84s0.87s
Check Time4.45s (± 0.50%)4.48s (± 0.45%)+0.03s (+ 0.74%)4.44s4.54s
Emit Time5.48s (± 0.28%)5.51s (± 0.41%)+0.03s (+ 0.55%)5.47s5.56s
Total Time12.35s (± 0.15%)12.44s (± 0.33%)+0.08s (+ 0.66%)12.34s12.55s
Monaco - node (v12.1.0, x64)
Memory used345,644k (± 0.02%)345,781k (± 0.01%)+138k (+ 0.04%)345,690k345,881k
Parse Time1.23s (± 1.01%)1.23s (± 0.50%)+0.00s (+ 0.33%)1.22s1.24s
Bind Time0.73s (± 0.68%)0.73s (± 0.41%)+0.01s (+ 0.83%)0.73s0.74s
Check Time4.49s (± 0.51%)4.54s (± 0.65%)+0.05s (+ 1.11%)4.47s4.60s
Emit Time3.02s (± 0.93%)3.01s (± 0.71%)-0.02s (- 0.56%)2.96s3.05s
Total Time9.46s (± 0.57%)9.51s (± 0.46%)+0.04s (+ 0.43%)9.39s9.57s
TFS - node (v12.1.0, x64)
Memory used304,060k (± 0.02%)304,316k (± 0.01%)+256k (+ 0.08%)304,226k304,394k
Parse Time0.95s (± 0.78%)0.95s (± 0.77%)-0.00s (- 0.21%)0.93s0.96s
Bind Time0.69s (± 1.22%)0.68s (± 0.65%)-0.01s (- 1.30%)0.67s0.69s
Check Time4.06s (± 0.24%)4.08s (± 0.27%)+0.03s (+ 0.62%)4.06s4.11s
Emit Time3.11s (± 0.50%)3.09s (± 0.91%)-0.02s (- 0.55%)3.03s3.15s
Total Time8.81s (± 0.28%)8.81s (± 0.37%)0.00s ( 0.00%)8.73s8.89s
Angular - node (v8.9.0, x64)
Memory used349,577k (± 0.01%)351,261k (± 0.01%)+1,684k (+ 0.48%)351,184k351,333k
Parse Time2.10s (± 0.42%)2.12s (± 0.39%)+0.02s (+ 0.95%)2.10s2.13s
Bind Time0.91s (± 1.09%)0.92s (± 0.56%)+0.01s (+ 1.43%)0.91s0.93s
Check Time5.27s (± 0.60%)5.34s (± 0.48%)+0.07s (+ 1.42%)5.29s5.39s
Emit Time6.16s (± 1.31%)6.23s (± 1.36%)+0.07s (+ 1.12%)6.05s6.39s
Total Time14.43s (± 0.71%)14.61s (± 0.66%)+0.18s (+ 1.23%)14.42s14.82s
Monaco - node (v8.9.0, x64)
Memory used363,742k (± 0.01%)363,922k (± 0.01%)+180k (+ 0.05%)363,835k363,973k
Parse Time1.56s (± 0.42%)1.57s (± 0.64%)+0.01s (+ 0.58%)1.55s1.60s
Bind Time0.93s (± 0.89%)0.93s (± 0.56%)+0.00s (+ 0.32%)0.92s0.94s
Check Time5.55s (± 0.75%)5.65s (± 0.79%)+0.11s (+ 1.89%)5.53s5.76s
Emit Time3.06s (± 0.63%)3.05s (± 0.68%)-0.00s (- 0.13%)2.98s3.08s
Total Time11.09s (± 0.42%)11.20s (± 0.48%)+0.11s (+ 0.99%)11.09s11.35s
TFS - node (v8.9.0, x64)
Memory used320,573k (± 0.01%)320,847k (± 0.01%)+274k (+ 0.09%)320,732k320,924k
Parse Time1.27s (± 0.35%)1.27s (± 0.49%)+0.00s (+ 0.24%)1.26s1.28s
Bind Time0.74s (± 0.65%)0.74s (± 0.70%)+0.00s (+ 0.54%)0.73s0.75s
Check Time4.72s (± 0.49%)4.80s (± 0.57%)+0.08s (+ 1.74%)4.74s4.85s
Emit Time3.25s (± 0.70%)3.26s (± 0.55%)+0.02s (+ 0.59%)3.23s3.30s
Total Time9.97s (± 0.38%)10.08s (± 0.37%)+0.10s (+ 1.04%)9.98s10.14s
Angular - node (v8.9.0, x86)
Memory used198,498k (± 0.02%)199,401k (± 0.03%)+903k (+ 0.45%)199,286k199,520k
Parse Time2.02s (± 0.52%)2.06s (± 0.68%)+0.03s (+ 1.68%)2.04s2.09s
Bind Time1.03s (± 1.43%)1.02s (± 0.54%)-0.01s (- 0.97%)1.01s1.04s
Check Time4.81s (± 0.72%)4.83s (± 0.84%)+0.02s (+ 0.48%)4.76s4.91s
Emit Time5.97s (± 0.70%)6.08s (± 1.63%)+0.11s (+ 1.76%)5.93s6.41s
Total Time13.84s (± 0.36%)13.99s (± 0.86%)+0.15s (+ 1.08%)13.76s14.34s
Monaco - node (v8.9.0, x86)
Memory used203,770k (± 0.01%)203,872k (± 0.02%)+102k (+ 0.05%)203,774k203,951k
Parse Time1.61s (± 0.75%)1.61s (± 0.54%)+0.00s (+ 0.31%)1.60s1.63s
Bind Time0.75s (± 0.69%)0.75s (± 0.74%)+0.00s (+ 0.40%)0.74s0.76s
Check Time5.39s (± 1.36%)5.49s (± 0.34%)+0.10s (+ 1.82%)5.45s5.54s
Emit Time2.92s (± 2.74%)2.86s (± 0.69%)-0.06s (- 2.09%)2.83s2.90s
Total Time10.67s (± 0.47%)10.72s (± 0.21%)+0.04s (+ 0.42%)10.66s10.76s
TFS - node (v8.9.0, x86)
Memory used180,574k (± 0.02%)180,738k (± 0.01%)+164k (+ 0.09%)180,677k180,815k
Parse Time1.31s (± 0.64%)1.31s (± 0.82%)+0.01s (+ 0.46%)1.29s1.34s
Bind Time0.70s (± 0.68%)0.70s (± 0.68%)-0.00s (- 0.00%)0.69s0.71s
Check Time4.49s (± 0.68%)4.50s (± 0.50%)+0.02s (+ 0.42%)4.47s4.56s
Emit Time2.97s (± 0.67%)2.98s (± 1.07%)+0.01s (+ 0.34%)2.91s3.06s
Total Time9.46s (± 0.38%)9.49s (± 0.56%)+0.04s (+ 0.37%)9.42s9.65s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory7 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
BenchmarkNameIterations
Current3059310
Baselinemaster10

@jack-williams

Jack Williams (jack-williams) commented Nov 26, 2019

Copy link
Copy Markdown
CollaboratorAuthor

TypeScript Bot (@typescript-bot) perf test this with recent CFA changes

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 26, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jack Williams (@jack-williams), I've started to run the perf test suite on this PR at 0a037d0. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

Jack Williams (@jack-williams)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..30593

Metricmaster30593DeltaBestWorst
Angular - node (v10.16.3, x64)
Memory used354,741k (± 0.02%)356,584k (± 0.02%)+1,843k (+ 0.52%)356,352k356,748k
Parse Time1.62s (± 0.60%)1.63s (± 0.51%)+0.01s (+ 0.31%)1.61s1.64s
Bind Time0.86s (± 0.43%)0.87s (± 0.66%)+0.00s (+ 0.58%)0.86s0.88s
Check Time4.54s (± 0.50%)4.53s (± 0.74%)-0.01s (- 0.20%)4.48s4.62s
Emit Time5.28s (± 0.69%)5.27s (± 0.91%)-0.01s (- 0.15%)5.17s5.37s
Total Time12.30s (± 0.38%)12.30s (± 0.54%)-0.00s (- 0.04%)12.19s12.48s
Monaco - node (v10.16.3, x64)
Memory used366,053k (± 0.02%)366,212k (± 0.02%)+159k (+ 0.04%)366,077k366,337k
Parse Time1.27s (± 0.80%)1.25s (± 0.61%)-0.01s (- 0.87%)1.24s1.27s
Bind Time0.76s (± 0.48%)0.76s (± 0.63%)+0.00s (+ 0.13%)0.75s0.77s
Check Time4.67s (± 0.42%)4.69s (± 0.55%)+0.02s (+ 0.41%)4.60s4.74s
Emit Time2.95s (± 1.02%)2.95s (± 0.87%)+0.00s (+ 0.17%)2.90s3.01s
Total Time9.64s (± 0.43%)9.65s (± 0.35%)+0.02s (+ 0.17%)9.59s9.74s
TFS - node (v10.16.3, x64)
Memory used321,930k (± 0.02%)322,166k (± 0.02%)+236k (+ 0.07%)322,015k322,336k
Parse Time0.95s (± 0.62%)0.96s (± 0.70%)+0.00s (+ 0.31%)0.95s0.98s
Bind Time0.73s (± 0.94%)0.72s (± 1.30%)-0.00s (- 0.41%)0.70s0.74s
Check Time4.11s (± 0.62%)4.13s (± 0.55%)+0.01s (+ 0.32%)4.08s4.18s
Emit Time3.06s (± 0.74%)3.03s (± 0.57%)-0.03s (- 0.91%)3.00s3.09s
Total Time8.85s (± 0.50%)8.84s (± 0.46%)-0.01s (- 0.14%)8.76s8.97s
Angular - node (v12.1.0, x64)
Memory used330,398k (± 0.02%)332,131k (± 0.02%)+1,733k (+ 0.52%)331,990k332,322k
Parse Time1.57s (± 0.49%)1.58s (± 0.62%)+0.01s (+ 0.45%)1.56s1.60s
Bind Time0.85s (± 0.87%)0.86s (± 0.69%)+0.01s (+ 0.71%)0.84s0.87s
Check Time4.45s (± 0.16%)4.46s (± 0.70%)+0.00s (+ 0.09%)4.37s4.50s
Emit Time5.52s (± 1.34%)5.47s (± 0.64%)-0.05s (- 0.85%)5.38s5.53s
Total Time12.39s (± 0.65%)12.36s (± 0.52%)-0.03s (- 0.23%)12.16s12.47s
Monaco - node (v12.1.0, x64)
Memory used345,758k (± 0.01%)345,966k (± 0.02%)+207k (+ 0.06%)345,830k346,097k
Parse Time1.23s (± 0.61%)1.23s (± 0.82%)+0.01s (+ 0.57%)1.22s1.27s
Bind Time0.73s (± 0.76%)0.73s (± 0.79%)+0.00s (+ 0.27%)0.72s0.74s
Check Time4.50s (± 0.33%)4.56s (± 0.47%)+0.06s (+ 1.42%)4.50s4.59s
Emit Time3.02s (± 0.39%)3.03s (± 0.78%)+0.01s (+ 0.46%)2.97s3.07s
Total Time9.47s (± 0.20%)9.56s (± 0.43%)+0.08s (+ 0.89%)9.42s9.62s
TFS - node (v12.1.0, x64)
Memory used304,274k (± 0.02%)304,514k (± 0.02%)+240k (+ 0.08%)304,316k304,663k
Parse Time0.95s (± 0.72%)0.96s (± 0.71%)+0.00s (+ 0.10%)0.94s0.97s
Bind Time0.68s (± 0.73%)0.69s (± 1.09%)+0.00s (+ 0.29%)0.67s0.70s
Check Time4.05s (± 0.40%)4.09s (± 0.52%)+0.05s (+ 1.16%)4.05s4.15s
Emit Time3.11s (± 0.77%)3.10s (± 0.26%)-0.01s (- 0.39%)3.09s3.12s
Total Time8.80s (± 0.27%)8.84s (± 0.31%)+0.04s (+ 0.45%)8.77s8.91s
Angular - node (v8.9.0, x64)
Memory used349,642k (± 0.01%)351,369k (± 0.01%)+1,727k (+ 0.49%)351,271k351,469k
Parse Time2.09s (± 0.45%)2.11s (± 0.41%)+0.02s (+ 0.91%)2.09s2.13s
Bind Time0.91s (± 0.75%)0.92s (± 0.48%)+0.02s (+ 1.77%)0.91s0.93s
Check Time5.32s (± 0.32%)5.33s (± 0.55%)+0.02s (+ 0.30%)5.25s5.39s
Emit Time6.27s (± 0.73%)6.26s (± 1.01%)-0.00s (- 0.03%)6.14s6.45s
Total Time14.59s (± 0.37%)14.63s (± 0.49%)+0.04s (+ 0.31%)14.54s14.82s
Monaco - node (v8.9.0, x64)
Memory used363,895k (± 0.01%)364,065k (± 0.01%)+169k (+ 0.05%)363,928k364,139k
Parse Time1.56s (± 0.63%)1.56s (± 0.38%)+0.00s (+ 0.13%)1.55s1.58s
Bind Time0.93s (± 0.91%)0.93s (± 0.71%)-0.00s (- 0.11%)0.92s0.94s
Check Time5.56s (± 0.59%)5.62s (± 0.58%)+0.06s (+ 1.08%)5.57s5.73s
Emit Time3.06s (± 0.66%)3.06s (± 0.61%)+0.01s (+ 0.20%)3.04s3.13s
Total Time11.11s (± 0.40%)11.18s (± 0.32%)+0.07s (+ 0.64%)11.11s11.28s
TFS - node (v8.9.0, x64)
Memory used320,894k (± 0.01%)321,142k (± 0.01%)+248k (+ 0.08%)321,071k321,204k
Parse Time1.27s (± 0.39%)1.27s (± 0.54%)0.00s ( 0.00%)1.25s1.28s
Bind Time0.74s (± 0.95%)0.74s (± 0.46%)+0.00s (+ 0.27%)0.74s0.75s
Check Time4.73s (± 0.38%)4.79s (± 0.47%)+0.07s (+ 1.40%)4.74s4.84s
Emit Time3.21s (± 0.43%)3.22s (± 0.57%)+0.01s (+ 0.34%)3.18s3.27s
Total Time9.94s (± 0.30%)10.02s (± 0.40%)+0.08s (+ 0.80%)9.93s10.10s
Angular - node (v8.9.0, x86)
Memory used198,609k (± 0.02%)199,520k (± 0.02%)+911k (+ 0.46%)199,422k199,623k
Parse Time2.03s (± 0.88%)2.05s (± 0.81%)+0.02s (+ 0.79%)2.02s2.09s
Bind Time1.05s (± 1.43%)1.02s (± 0.86%)-0.03s (- 2.95%)1.01s1.05s
Check Time4.83s (± 0.63%)4.84s (± 0.53%)+0.01s (+ 0.17%)4.77s4.90s
Emit Time6.12s (± 1.09%)6.12s (± 1.54%)+0.00s (+ 0.03%)5.96s6.37s
Total Time14.03s (± 0.46%)14.03s (± 0.85%)-0.00s (- 0.02%)13.84s14.35s
Monaco - node (v8.9.0, x86)
Memory used203,872k (± 0.03%)203,973k (± 0.02%)+101k (+ 0.05%)203,893k204,068k
Parse Time1.61s (± 0.61%)1.61s (± 0.73%)-0.00s (- 0.19%)1.59s1.65s
Bind Time0.76s (± 1.41%)0.75s (± 0.78%)-0.01s (- 1.06%)0.74s0.76s
Check Time5.42s (± 0.54%)5.42s (± 1.22%)+0.00s (+ 0.07%)5.16s5.48s
Emit Time2.91s (± 0.99%)2.91s (± 2.77%)-0.00s (- 0.07%)2.85s3.23s
Total Time10.69s (± 0.27%)10.69s (± 0.29%)-0.01s (- 0.07%)10.63s10.75s
TFS - node (v8.9.0, x86)
Memory used180,831k (± 0.01%)180,987k (± 0.02%)+157k (+ 0.09%)180,906k181,059k
Parse Time1.31s (± 0.81%)1.31s (± 0.69%)-0.00s (- 0.23%)1.30s1.34s
Bind Time0.70s (± 0.74%)0.70s (± 1.07%)-0.00s (- 0.29%)0.69s0.72s
Check Time4.49s (± 0.52%)4.51s (± 0.57%)+0.02s (+ 0.51%)4.46s4.58s
Emit Time2.98s (± 1.16%)2.98s (± 0.51%)+0.00s (+ 0.00%)2.95s3.02s
Total Time9.48s (± 0.50%)9.50s (± 0.39%)+0.02s (+ 0.24%)9.41s9.58s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
BenchmarkNameIterations
Current3059310
Baselinemaster10

@sandersnNathan Shively-Sanders (sandersn) added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
@weswighamWesley Wigham (weswigham) mentioned this pull request Mar 9, 2020
Merged
@weswighamWesley Wigham (weswigham) mentioned this pull request May 4, 2020
Merged
Closed
@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ahejlsbergAnders Hejlsberg (ahejlsberg)Awaiting requested review from ahejlsberg

Assignees

@ahejlsbergAnders Hejlsberg (ahejlsberg)

Labels

For Backlog BugPRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unknown types narrowed to a union won't narrow further

7 participants

@jack-williams@Validark@RyanCavanaugh@typescript-bot@DanielRosenwasser@ahejlsberg@sandersn