PHP 7.x compatibility - #82
Merged
Merged
Conversation
match() is only available in PHP 8
MightyMCoder
requested changes
May 21, 2025
MightyMCoder
left a comment
Owner
There was a problem hiding this comment.
This solution will work fine but please use this instead:
$contentTypes = array(
'csv' => 'text/csv; charset=' . $charset,
'xlsx' => 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'ods' => 'application/vnd.oasis.opendocument.spreadsheet',
);
$writerClasses = array(
'csv' => Csv::class,
'xlsx' => Xlsx::class,
'ods' => Ods::class,
);
if (!isset($contentTypes[$getMode], $writerClasses[$getMode])) {
thrownewInvalidArgumentException('Invalid mode');
}
$contentType = $contentTypes[$getMode];
$writerClass = $writerClasses[$getMode];Rvice
commented
May 21, 2025
ContributorAuthor
Changed and also added a translation for the default category |
MightyMCoder
self-requested a review
May 21, 2025 22:44
MightyMCoder
approved these changes
May 21, 2025
MightyMCoder
left a comment
Owner
There was a problem hiding this comment.
thanks for the implementation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#81
Also added translation for default category, unfortunately, I don't understand German.