fix(comfyui-studio): correct character and drama YAML front matter - #35
Merged
Merged
Conversation
weekbin
added a commit
to weekbin/MiniMax-Code-Plugins
that referenced
this pull request
Sep 10, 2026
…audit This commit hardens the Plugin to the MiniMax Marketplace submission guide + the historical PR review pattern from MiniMax-Code-Plugins (PRs MiniMax-AI#4, MiniMax-AI#21, MiniMax-AI#33, MiniMax-AI#35, MiniMax-AI#37): - Add `.minimax-plugin/plugin.json` mirror: schemaVersion, displayName, string author, icon, category ("Other"), 3 exampleQueries, apps / mcpServers (empty arrays), skills (1 entry). The closed-schema `plugin.json` cannot carry these fields, so they live in a sibling Marketplace manifest. - Add `icon.png` (1080x1080 RGBA, 457 KB) per the user-provided art. - Extend `plugin.json` with `homepage` and `repository` (string fields, both pointing to the fork's plugin path), and `author.email`. - Rewrite the description in user-facing language ("Generate ... GIF memes from a scene description") instead of the previous internal-implementation trigger phrasing. - Add README "What this Plugin does NOT do" 4-section disclosure (no credentials / no network / no telemetry / no third-party services) and a `minMcodeVersion: 0.2.0` requirement line. - Add `license` and `metadata` keys to SKILL.md frontmatter. - Add `tests/plugins/octopus-meme-maker/smoke.test.mjs` with 20 static checks + 5 negative-injection tests. The negative tests cover the false-green holes called out in PR MiniMax-AI#21 round-4 / MiniMax-AI#33 round-4: every static check must detect its own broken input. The path sweep now covers all `.md` / `.py` / `.json` in the plugin, not just SKILL.md and the marketplace JSON, so future regressions cannot slip through. - Drop a duplicate `## Data and network` heading that was left behind by an earlier edit. - Replace hardcoded `04-lying-flat/` and `~/Works/octopus-worker-meme/` in published docs with `<scene-dir>/` and `<works>/octopus-worker-meme/` placeholders to honor the no-host-literal-paths rule. Verified: `npm run check` 221/221 pass; skill-review audit 100% PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
comfyui-characterandcomfyui-dramaskill descriptions contain colon-space sequences in unquoted YAML values, causing GitHub to show “mapping values are not allowed in this context” instead of rendering their front matter.Use folded block scalars (
>-) for both descriptions. The parsed description strings and Markdown bodies remain unchanged.Validation:
npm run check: repository validation and all 128 tests passed.git diff --check: passed.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.