Conversation
|
Related: #47 (zh/en term-consistency audit) — same spirit as the claims table here, extending mechanical checks from behavior to documentation. No action needed on this PR. |
a950f42 to
8d4a56e
Compare
hetaoBackend
left a comment
There was a problem hiding this comment.
Request changes for exact current head 8d4a56e.
Blocking issues:
- The PR changes the maintained
plugins/hetaoBackend/mcode-dynamic-workflows/tree, while the PR author/commits aremodacker/moc <moc@sgmov.com>and the manifests still identifyhetaoBackendas owner (plugin.json:6,.claude-plugin/plugin.json:5). UnderCONTRIBUTING.md:28,80, provide explicit owner authorization or move the change to the contributor's own plugin scope before merge. scripts/verify-claims.mjs:10-17extracts Markdown cells and passes each cell directly to/bin/sh -c. This turns a modified verification document into arbitrary local command execution, with no allowlist for commands/argv or shell metacharacters. Replace it with structured, fixed commands/argv (or an explicit documented trusted-only policy plus strict validation); do not use an unrestricted shell for a claims verifier.- The parser only collects rows matching one regex (
verify-claims.mjs:12) and silently ignores malformed/unexpected/duplicate rows. It can exit 0 after verifying a subset while claiming “every row”. Validate the header, exact expected IDs/order, uniqueness, columns, and that every table row is consumed; add focused parser tests. - The new verifier and
examples/reflection.jsare not executed by the current CI workflow. The green checks cover the existing 73 source checks and package test, but notnode scripts/verify-claims.mjsorvalidateScripton the reflection example. Add both checks to CI and provide exact-head output. examples/reflection.js:12-15gives the revision agent the draft and critique but not the originaltask/materialpassed to the critic. The runtime contract says agents are self-contained and do not inherit the parent conversation; the revision cannot independently verify the critique evidence. Pass the original material (or a bounded equivalent) to revision and add a regression assertion.
The current [code]smith check is SKIPPED and is not evidence. Reconcile the ownership issue and add the missing executable CI evidence before approval.
- VERIFICATION.md gains a verify-fenced claims table; the new scripts/verify-claims.mjs executes each row and exits 0 only when all match (1 first mismatch, 2 tool failure) - examples/reflection.js: draft -> independent critique -> revision formation with a checkpoint snapshot, styled after audit.js
8d4a56e to
b3b8acc
Compare
…elated to this PR)
|
Note on the failing |
|
Thank you for the exact-head review — all five blockers are actionable. Point-by-point:
Rework incoming on this branch; will re-request review against the exact new head. |
What changes
VERIFICATION.md+scripts/verify-claims.mjs): the claims a machine can re-check are tabulated in a```verifyfenced block. The runner executes each row via/bin/sh -c, prints one PASS/FAIL line per claim, and exits 0 only when every row matches its expected exit status (1 on the first mismatch, 2 when the tool itself cannot run). Rows needing development dependencies say so (npm cifirst); non-mechanical claims (dashboard acceptance, real-agent calls, platform coverage) intentionally stay prose.examples/reflection.js): draft → independent critique → revision, three phases with separate agents, a checkpoint snapshot of the draft, and explicit open-issue handling — styled afterexamples/audit.js.Verification
node scripts/verify-claims.mjs: 4/4 PASS on a committed tree. V-04 failing on a dirty tree is the feature: it detects drifted committed assets.examples/reflection.jspassesvalidateScriptnpm run check: greenNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.